Or 1948 make l1 contracts deploy script #309

nguyenzung · 2024-12-06T04:52:40Z

Script for deploy smart contract using configf file and .env file.
Deploying smart contracts includes some steps:

install and build software
Deploy smart contracts
Generate rollup and genesis files

Tested on: Ubuntu22.04, Debian:12
Arch: amd64

We can do the 3 steps above by one command:
./start-deploy.sh all -c /tokamak-thanos/packages/tokamak/contracts-bedrock/deploy-config/devnetL1.json -e .env

It is possible if there are issues happened. In these cases, we can retry each steps

Deploy contracts
./start-deploy.sh deploy -c /tokamak-thanos/packages/tokamak/contracts-bedrock/deploy-config/devnetL1.json -e .env
Generate rollup and genesis files
./start-deploy.sh generate -c /tokamak-thanos/packages/tokamak/contracts-bedrock/deploy-config/devnetL1.json -e .env

Thank you!

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

theo-learner · 2024-12-11T07:25:58Z

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

+  source ~/.bashrc
+  cd $projectRoot
+  pnpm install
+  make submodules


In a dependency installation, Go appears to be installed fine, but Go is not found here. Can you please check?

I updated it. Actually, there is no problem when I tested.
Please let me know if you still have this error.

Now I found some error during make cannon-prestate and make op-node and the error log is here:

make[1]: *** [Makefile:24: op-program-host] Error 1 make[1]: Leaving directory '/tokamak-thanos/op-program' make: *** [Makefile:138: op-program] Error 2 make -C ./op-node op-node make[1]: Entering directory '/tokamak-thanos/op-node' env GO111MODULE=on GOOS= GOARCH= go build -v -ldflags "-X main.GitCommit=1e6182502150c049ae354370a7d7165cf249cb0d -X main.GitDate=1733470411 -X github.com/ethereum-optimism/optimism/op-node/version.Version=untagged -X github.com/ethereum-optimism/optimism/op-node/version.Meta=" -o ./bin/op-node ./cmd/main.go runtime/cgo github.com/tokamak-network/tokamak-thanos/op-service/ioutil # runtime/cgo gcc: error: unrecognized command-line option '-m64' github.com/tokamak-network/tokamak-thanos/op-service/jsonutil make[1]: *** [Makefile:29: op-node] Error 1 make[1]: Leaving directory '/tokamak-thanos/op-node' make: *** [Makefile:110: op-node] Error 2

However, we don't need to build whole packages to deploy contracts to L1. So we can remove this part if we need much time to resolve the issue.

the gcc version in my env:

gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/lib/gcc/aarch64-linux-gnu/11/lto-wrapper Target: aarch64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 11.4.0-1ubuntu1~22.04' --with-bugurl=file:///usr/share/doc/gcc-11/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-11 --program-prefix=aarch64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-libquadmath --disable-libquadmath-support --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --enable-fix-cortex-a53-843419 --disable-werror --enable-checking=release --build=aarch64-linux-gnu --host=aarch64-linux-gnu --target=aarch64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2 Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)

I think we can start supporting AMD64 first, because it is enough for TRH project. Your problems relate to an ARM64 CPU.

We need op-node for generate L2 config files and cannon-prestate for compiling smart contracts related to Fault Proof

Sorry, we've already had this conversation. Thanks for checking in!

ohbyeongmin · 2024-12-12T04:24:13Z

Which env file should we use?

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

ohbyeongmin · 2024-12-12T04:41:25Z

Is configFilePath an absolute path only?

nguyenzung · 2024-12-12T08:34:22Z

Is configFilePath an absolute path only?

It can be relative!
Ah, yes, I need to update a case. Thank you!

nguyenzung · 2024-12-12T09:00:40Z

Which env file should we use?

I added packages/tokamak/contracts-bedrock/scripts/env.example.deploy as an example env

packages/tokamak/contracts-bedrock/scripts/env.example.deploy

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

ohbyeongmin · 2024-12-13T04:49:30Z

Can you rebase this branch from main?

nguyenzung · 2024-12-13T06:56:31Z

Can you rebase this branch from main?

It is done.
Actually, this feature is isolated and contains new files, so it is ok if we would not rebase.

ohbyeongmin · 2024-12-17T04:09:54Z

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

+
+generateL2Genesis() {
+  echo "Generate L2 genesis"
+  deployResultFile=$projectRoot/packages/tokamak/contracts-bedrock/deployments/$(printf "%d-deploy.json" "$chainID")


When I run the deploy command, sometimes the deploy result file is generated as artifact.json instead of {chainID}-deploy.json.

Could you check this issue?

I am checking, still not found anything. Could you give me the config file and the environment variables?

Oh. i'm so sorry!!

echo $DEPLOYMENT_OUTFILE deployments/artifact.json

The issue was due to an environment variable I had set earlier.
Now that this commit is in place, there’s no need to worry. Thank you!

Thank you for your checking!

I fixed it randomly ^^

theo-learner

Thank you so much!

theo-learner · 2024-12-17T07:37:29Z

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh

+  source ~/.bashrc
+  cd $projectRoot
+  pnpm install
+  make submodules


Sorry, we've already had this conversation. Thanks for checking in!

ohbyeongmin

LGTM! Thank you!

nguyenzung requested review from theo-learner, ohbyeongmin, AaronLee22, xxeonge and 0x6e616d December 6, 2024 07:33

nguyenzung self-assigned this Dec 6, 2024

theo-learner reviewed Dec 11, 2024

View reviewed changes

nguyenzung marked this pull request as draft December 11, 2024 15:04

nguyenzung requested a review from swywssaid December 11, 2024 15:12

ohbyeongmin reviewed Dec 12, 2024

View reviewed changes

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh Show resolved Hide resolved

ohbyeongmin requested changes Dec 13, 2024

View reviewed changes

packages/tokamak/contracts-bedrock/scripts/env.example.deploy Outdated Show resolved Hide resolved

ohbyeongmin requested changes Dec 13, 2024

View reviewed changes

packages/tokamak/contracts-bedrock/scripts/start-deploy.sh Outdated Show resolved Hide resolved

nguyenzung marked this pull request as ready for review December 13, 2024 03:40

nguyenzung requested review from ohbyeongmin and theo-learner December 13, 2024 03:41

nguyenzung added 10 commits December 13, 2024 13:53

add start-deploy.sh script

25ba1d4

update software version

fe59aa7

update scrip files

cd7d4ff

update build source

9c76651

update script

8483677

fix the execution path

5947407

generate rollup.json and genesis.json

6b99c7d

fix checking go

ca4a0ec

calculate prestate for cannon

5997f58

add multiple command, useful for retry

de5cd85

nguyenzung added 16 commits December 13, 2024 13:53

update salt

c638b6c

optimize script

afdf070

disable interaction

5b3fb97

clean code

7c17f9b

test dev for debian

212c2d7

update output file name template

50f5672

force update go path

34e40df

add example file .env

adcf0cb

fix relative paths

3413ddb

add relative paths

970647a

update fs permission

3b22416

support relative config file dir

a32f7d7

fix typo

6f4966f

update example config

0d459af

remove chainID from filename

dfeeced

update guidance

0d906c9

nguyenzung force-pushed the OR-1948-make-L1-contracts-deploy-script branch from d5a5e61 to 0d906c9 Compare December 13, 2024 06:53

rollback config file for forge

6e3d165

ohbyeongmin reviewed Dec 17, 2024

View reviewed changes

theo-learner approved these changes Dec 17, 2024

View reviewed changes

unset env to use cmd directly

97ffdf5

ohbyeongmin approved these changes Dec 18, 2024

View reviewed changes

nguyenzung merged commit f491301 into main Dec 18, 2024
11 of 15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Or 1948 make l1 contracts deploy script #309

Or 1948 make l1 contracts deploy script #309

nguyenzung commented Dec 6, 2024 •

edited

Loading

theo-learner Dec 11, 2024

nguyenzung Dec 12, 2024

theo-learner Dec 17, 2024 •

edited

Loading

theo-learner Dec 17, 2024

nguyenzung Dec 17, 2024 •

edited

Loading

theo-learner Dec 17, 2024

ohbyeongmin commented Dec 12, 2024

ohbyeongmin commented Dec 12, 2024

nguyenzung commented Dec 12, 2024 •

edited

Loading

nguyenzung commented Dec 12, 2024

ohbyeongmin commented Dec 13, 2024

nguyenzung commented Dec 13, 2024

ohbyeongmin Dec 17, 2024

nguyenzung Dec 18, 2024

ohbyeongmin Dec 18, 2024

nguyenzung Dec 18, 2024

theo-learner left a comment

theo-learner Dec 17, 2024

ohbyeongmin left a comment

Or 1948 make l1 contracts deploy script #309

Or 1948 make l1 contracts deploy script #309

Conversation

nguyenzung commented Dec 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theo-learner Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nguyenzung Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohbyeongmin commented Dec 12, 2024

ohbyeongmin commented Dec 12, 2024

nguyenzung commented Dec 12, 2024 • edited Loading

nguyenzung commented Dec 12, 2024

ohbyeongmin commented Dec 13, 2024

nguyenzung commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theo-learner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ohbyeongmin left a comment

Choose a reason for hiding this comment

nguyenzung commented Dec 6, 2024 •

edited

Loading

theo-learner Dec 17, 2024 •

edited

Loading

nguyenzung Dec 17, 2024 •

edited

Loading

nguyenzung commented Dec 12, 2024 •

edited

Loading