Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gitlab gitkeep issue #3199

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix gitlab gitkeep issue #3199

wants to merge 4 commits into from

Conversation

akshay-gupta7
Copy link
Contributor

Why does this PR exist?

Fixes #3160

What does this pull request do?

Testing this change

Additional Notes (if any)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 39aa18a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 4, 2024
View reviewed changes
packages/tokens-studio-for-figma/src/storage/GitlabTokenStorage.ts
try {
await this.gitlabClient.Commits.create(this.projectId, this.branch, 'Deleting unnecessary .gitkeep files', gitkeepDeletions);
} catch (e) {
console.error('Failed to delete .gitkeep files:', e);

Check warning

Code scanning / ESLint

disallow the use of `console` Warning

Unexpected console statement.
packages/tokens-studio-for-figma/src/storage/GitlabTokenStorage.ts
{ action: 'delete', filePath: gitkeepPath },
]);
} catch (e: any) {
console.error(`Failed to delete .gitkeep: ${e}`);

Check warning

Code scanning / ESLint

disallow the use of `console` Warning

Unexpected console statement.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Commit SHA:a3f6c8a8719b52461b455e3086e1fdc0133ef758

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-gitlab-gitkeep-issue
Status File % Stmts % Branch % Funcs % Lines
🔴 total 66.87 (-0.08) 57.68 (-0.03) 63.78 (0.02) 67.22 (-0.07)
🔴 packages/tokens-studio-for-figma/src/storage/GitlabTokenStorage.ts 53.62 (-6.38) 45.65 (-2.12) 54.16 (2.16) 54.47 (-5.9)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Commit SHA:a3f6c8a8719b52461b455e3086e1fdc0133ef758
Current PR reduces the test coverage percentage by 1 for some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with .gitkeep Files and Branch Switching
1 participant
@akshay-gupta7