Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed multiple token dimension values(#320) #332

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

florin01hyma
Copy link
Contributor

sd-transforms now supports introducing multiple values for size tokens. If '8 16' is transmitted, it is transformed to '8px 16px'. Before, that was only happening when a single value was written.

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: cda41b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/sd-transforms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@florin01hyma florin01hyma linked an issue Nov 22, 2024 that may be closed by this pull request
1 task
src/transformDimension.ts Outdated Show resolved Hide resolved
Copy link
Member

@jorenbroekema jorenbroekema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 nitpicks (optional), 1 change requested in tests that's not nitpick

src/transformDimension.ts Outdated Show resolved Hide resolved
src/transformDimension.ts Outdated Show resolved Hide resolved
test/spec/transformDimension.spec.ts Outdated Show resolved Hide resolved
@florin01hyma
Copy link
Contributor Author

2 nitpicks (optional), 1 change requested in tests that's not nitpick

All three comments addressed

@jorenbroekema jorenbroekema merged commit e0aab62 into main Dec 4, 2024
2 checks passed
@jorenbroekema jorenbroekema deleted the multiple-values branch December 4, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support for multiple values in tokens
2 participants