Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulation testing via turmoil #113

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

LucioFranco
Copy link
Member

@LucioFranco LucioFranco commented Jan 9, 2023

This adds basic simulation testing via turmoil to mini-redis. This approach uses trait objects to avoid feature flags.

@LucioFranco LucioFranco changed the title Add simulation testing version 2 Add simulation testing via turmoil Jan 10, 2023
@LucioFranco LucioFranco marked this pull request as ready for review January 10, 2023 17:26
@LucioFranco
Copy link
Member Author

I prefer this approach over the cfg flag version here #112

@carllerche
Copy link
Member

IMO, I'm w/ @Darksonn here. I think Turmoil is out of scope for mini-redis. Mini-redis is intended to be one of the first introductions to Tokio. The Tokio tutorial is based on it. Simulation testing, pros and cons, when to use it, etc... are all more advanced topics which should be addressed separately IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants