Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to windows-sys v0.52 #1774

Closed
wants to merge 1 commit into from

Conversation

skyfloogle
Copy link

This is just a cherry-pick of the corresponding commit from the master branch. Required for building on certain targets on newer versions of Rust (see microsoft/windows-rs#2774).

@skyfloogle skyfloogle requested a review from carllerche as a code owner April 14, 2024 13:02
@Thomasdezeeuw
Copy link
Collaborator

Cherry-pick of commit eea9e3e.

Note to self add this to the commit when merging.

@skyfloogle
Copy link
Author

Looks like this would require a MSRV increase to v1.56, which I understand goes against mio's policy. Does this mean building these targets on Rust v1.76+ will have to wait until v1.0 is stabilized?

@Thomasdezeeuw
Copy link
Collaborator

Looks like this would require a MSRV increase to v1.56, which I understand goes against mio's policy. Does this mean building these targets on Rust v1.76+ will have to wait until v1.0 is stabilized?

Yes, I'm afraid so.

@skyfloogle
Copy link
Author

In that case, I'll close the pull request.
On the bright side, after further investigation, I found out this doesn't actually block me, as my project only uses mio as a transitive dependency which isn't actually invoked on Windows.
Apologies for the confusion, and good luck with future developments!

@skyfloogle skyfloogle closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants