fix: Update incorrect tracing-futures feature docs #2802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI test fail fixed in #2798 |
jayvdb
force-pushed
the
update-tracing-futures-feature-docs
branch
from
20930de
to
04a3436
Compare
|
Rebased, and waiting for workflow approval for this and also for #2800 |
mladedav
approved these changes
May 15, 2024
|
ping @mladedav , do I need to rebase this? |
|
I think @davidbarsky just needs to get around to merging master into this and then merging this into master. I don't think this will have any conflicts so I don't think you need to rebase or manually merge anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The docs about the features is incorrect. c.f. #2799
Solution
Remove reference to feature
tokio-alphawhich no longer exists, and mention that featuretokiois only needed for tokio v0.1 support.