Merge pull request #6 from tolerious/feat/refactor-create-group-logic

🚧 Refactor create group logic.

routes/wordGroup.js

@@ -1,5 +1,5 @@
 const express = require("express");
-const { generateResponse } = require("../utils/utils");
+const { generateResponse, generateBadResponse } = require("../utils/utils");
 const { wordGroupModel } = require("../schemas/wordGroupSchema");
 const { userSettingModel } = require("../schemas/userSettingsSchema");
 const router = express.Router();
@@ -29,22 +29,56 @@ router.get("/child", async function (req, res, next) {
   res.json(generateResponse(t));
 });
 
-// 创建词组
+// 创建词组,createdSource必传
 router.post("/", async function (req, res, next) {
   let user = req.tUser;
-  let body = req.body;
-  const { name } = req.body;
-  const groups = await wordGroupModel.find({ name: name });
-  if (groups.length > 0) {
-    res.json(generateResponse(groups[0], 200, "Group exist."));
-  } else {
-    Object.assign(body, {
-      nickName: name,
-      creator: user._id,
-      parentGroupID: "",
-    });
-    let t = await wordGroupModel.create(body);
-    res.json(generateResponse(t));
+  // 检查创建来源
+  const { createdSource, originalPageUrl, name } = req.body;
+  if (!createdSource) {
+    res.json(generateResponse("", 400, "data format not correct"));
+    return;
+  }
+  switch (createdSource) {
+    case "extension": {
+      if (!originalPageUrl) {
+        res.json(generateResponse("", 400, "data format not correct"));
+        return;
+      }
+      const groups = await wordGroupModel.getGroupsByOriginalPageUrlAndUserId(
+        originalPageUrl,
+        user
+      );
+      if (groups.length === 0) {
+        const g = await wordGroupModel.create({
+          ...req.body,
+          creator: user._id,
+        });
+        res.json(generateResponse(g, 200));
+      } else {
+        const g = groups[0];
+        res.json(generateResponse(g, 200));
+      }
+      return;
+    }
+    case "manually": {
+      if (!name) {
+        res.json(generateBadResponse());
+      }
+      const groups = await wordGroupModel.getGroupByNameAndUserId(name, user);
+      if (groups.length === 0) {
+        const g = await wordGroupModel.create({
+          ...req.body,
+          creator: user._id,
+        });
+        res.json(generateResponse(g));
+      } else {
+        res.json(generateResponse(groups[0], 200, "exist"));
+      }
+      return;
+    }
+    default:
+      res.json(generateResponse("", 400));
+      break;
   }
 });
 
@@ -57,6 +91,7 @@ router.post("/detail", async function (req, res, next) {
   else g = Object.assign(g, { hasChild: false });
   res.json(generateResponse(g));
 });
+
 router.delete("/", async function (req, res, next) {
   let id = req.body.id;
   let group = await wordGroupModel.findById(id);
@@ -77,6 +112,7 @@ router.delete("/", async function (req, res, next) {
     res.json(generateResponse(t));
   }
 });
+
 router.get("/public", async function (req, res, next) {
   let groupList = await wordGroupModel.getPublicGroup();
   res.json(generateResponse(groupList));

schemas/wordGroupSchema.js

@@ -7,6 +7,14 @@ const wordGroupSchema = new Schema(
   {
     // 用作标识group是否唯一
     name: { type: String, default: "Default" },
+    // 使用浏览器插件查询单词的时候获取到的当前页面的url
+    originalPageUrl: { type: String, default: "" },
+    // 词组被创建的来源,是浏览器插件功能自动创建的，还是手动创建的，还是在stylish reader官网上youtube视频创建的
+    createdSource: {
+      type: String,
+      enum: ["extension", "manually"],
+      required: true,
+    },
     // 用作页面上显示的名字
     nickName: { type: String, default: "Default" },
     // 是否时官方的词组
@@ -23,11 +31,17 @@ const wordGroupSchema = new Schema(
     // 词组对应的文章，视频链接，等所有资料链接
     links: { type: Array, default: [] },
     // 通过 stylish reader 网站的youtube视频添加的词组，会有这个字段
-    youtubeId:{type:String,default:''}
+    youtubeId: { type: String, default: "" },
   },
   {
     timestamps: true,
     statics: {
+      getGroupByNameAndUserId(name, user) {
+        return this.find({ name, creator: user._id });
+      },
+      getGroupsByOriginalPageUrlAndUserId(originalPageUrl, user) {
+        return this.find({ originalPageUrl, creator: user._id });
+      },
       getOnlyChildGroup(creator) {
         return mongoose.model("WordGroup").find({
           creator: creator,

utils/utils.js

@@ -9,6 +9,14 @@ function generateResponse(data = "", code = 200, msg = "success") {
   };
 }
 
+function generateBadResponse(data = "", msg = "Bad Request") {
+  return {
+    code: 400,
+    msg,
+    data,
+  };
+}
+
 async function grabWordFromCambridge(word) {
   let url = `https://dictionary.cambridge.org/dictionary/english-chinese-simplified/${word}`;
   let r = await axios.get(url);
@@ -209,4 +217,8 @@ async function grabWordFromCambridge(word) {
   return entryBodyElList;
 }
 
-module.exports = { generateResponse, grabWordFromCambridge };
+module.exports = {
+  generateResponse,
+  grabWordFromCambridge,
+  generateBadResponse,
+};