Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remux prerm script fails on reenable #638

Closed
Jayy001 opened this issue Oct 14, 2022 · 1 comment · Fixed by #721
Closed

remux prerm script fails on reenable #638

Jayy001 opened this issue Oct 14, 2022 · 1 comment · Fixed by #721
Labels
bug Something isn't working packages Add or improve packages of the repository

Comments

@Jayy001
Copy link

Jayy001 commented Oct 14, 2022

Just did a fresh update from 2.14.1.866 to 2.14.3.1005 (Have not installed ddvk-hacks, can confirm everything is working fine)

After running toltecctl reenable, it does throw an error which it shouldn't do over a unit file not existing.

Full log:

reMarkable: ~/ toltecctl reenable
Mounting '/home/root/.entware' over '/opt'
Created symlink /etc/systemd/system/local-fs.target.wants/opt.mount → /lib/systemd/system/opt.mount.
Downloading https://bin.entware.net/armv7sf-k3.2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/entware
Downloading https://toltec-dev.org/stable/rmall/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec-rmall
Downloading https://toltec-dev.org/stable/rm2/Packages.gz
Updated list of available packages in /opt/var/opkg-lists/toltec-rm2
Removing package xochitl from root...
Removing package toltec-bootstrap from root...
Removing package rm2fb-client from root...
Removing package reboot-guard from root...
Removing package rm2-suspend-fix from root...
Removing package tarnish from root...
Removing package display from root...
make sure to disable / uninstall any launchers like draft, oxide or remux before
rebooting your tablet to complete the uninstallation
Removing package remux from root...
Disabling remux
Failed to disable unit: Unit file remux.service does not exist.
Removing package libvncclient from root...
Installing xochitl (0.0.0-13) to root...
Downloading https://toltec-dev.org/stable/rmall/xochitl_0.0.0-13_rmall.ipk
Installing toltec-bootstrap (0.2.2-1) to root...
Downloading https://toltec-dev.org/stable/rmall/toltec-bootstrap_0.2.2-1_rmall.ipk
Installing rm2fb-client (1:0.0.23-1) to root...
Downloading https://toltec-dev.org/stable/rm2/rm2fb-client_1_0.0.23-1_rm2.ipk
Installing rm2fb-client (1:0.0.23-1) to root...
Installing display (1:0.0.23-1) to root...
Downloading https://toltec-dev.org/stable/rm2/display_1_0.0.23-1_rm2.ipk
Installing reboot-guard (1.0.1-6) to root...
Downloading https://toltec-dev.org/stable/rmall/reboot-guard_1.0.1-6_rmall.ipk
Installing rm2-suspend-fix (0.0.0-2) to root...
Downloading https://toltec-dev.org/stable/rm2/rm2-suspend-fix_0.0.0-2_rm2.ipk
Installing tarnish (2.4-1) to root...
Downloading https://toltec-dev.org/stable/rmall/tarnish_2.4-1_rmall.ipk
Installing libsentry (0.4.17) to root...
Downloading https://toltec-dev.org/stable/rmall/libsentry_0.4.17_rmall.ipk
Installing liboxide (2.4-1) to root...
Downloading https://toltec-dev.org/stable/rmall/liboxide_2.4-1_rmall.ipk
Package display (1:0.0.23-1) installed in root is up to date.
Installing remux (0.2.3-1) to root...
Downloading https://toltec-dev.org/stable/rmall/remux_0.2.3-1_rmall.ipk
Installing libvncclient (0.9.13-2) to root...
Downloading https://toltec-dev.org/stable/rmall/libvncclient_0.9.13-2_rmall.ipk
Configuring toltec-bootstrap.
Configuring rm2-suspend-fix.
Configuring xochitl.
Configuring display.
Created symlink /etc/systemd/system/multi-user.target.wants/rm2fb.service → /lib/systemd/system/rm2fb.service.
Configuring rm2fb-client.
Configuring libvncclient.
Configuring libsentry.
Configuring liboxide.
Configuring tarnish.
Configuring remux.

Run the following command(s) to use remux as your launcher
$ systemctl enable --now remux

Configuring reboot-guard.
Collected errors:
 * pkg_run_script: package "remux" prerm script returned status 1.
@matteodelabre matteodelabre changed the title Toltec reenable gives unit file error remux prerm script fails on reenable Nov 21, 2022
@matteodelabre matteodelabre added bug Something isn't working packages Add or improve packages of the repository labels Nov 21, 2022
@matteodelabre
Copy link
Member

matteodelabre commented Nov 21, 2022

We should replace the call to systemctl disable --now remux in preremove with something similar to what is done for tarnish.

if is-active tarnish; then
echo "Stopping tarnish"
systemctl stop tarnish
fi
if is-enabled tarnish; then
echo "Disabling tarnish"
systemctl disable tarnish
fi

This should probably be made into a command in install-lib to avoid repetition.

Eeems added a commit that referenced this issue Aug 18, 2023
@Eeems Eeems linked a pull request Aug 18, 2023 that will close this issue
@Eeems Eeems added this to the 2023-W49 Merge Window milestone Dec 8, 2023
Eeems added a commit that referenced this issue Dec 10, 2023
Eeems added a commit that referenced this issue Dec 10, 2023
@Eeems Eeems closed this as completed Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants