Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up systemd unit disable logic #721

Merged
merged 16 commits into from
Dec 10, 2023
Merged

Clean up systemd unit disable logic #721

merged 16 commits into from
Dec 10, 2023

Conversation

Eeems
Copy link
Member

@Eeems Eeems commented Aug 18, 2023

Add the following to install-lib:

  • unit-exists
  • disable-unit

Update all packages to use disable-unit

@Eeems Eeems added packages Add or improve packages of the repository tooling Set of scripts and configuration files for building the packages labels Aug 18, 2023
@Eeems Eeems linked an issue Aug 18, 2023 that may be closed by this pull request
@Eeems Eeems added this to the 2023-W34 Merge window milestone Aug 18, 2023
@rM-self-serve
Copy link
Contributor

I only tested webinterface-wifi but works for me.

disable_logic

disable_logic2

Jayy001
Jayy001 previously approved these changes Dec 8, 2023
@Eeems
Copy link
Member Author

Eeems commented Dec 8, 2023

As part of double-checking to make sure everything is covered, I noticed that innernet doesn't manage its services at all on uninstall and opened #779 779

@Eeems Eeems requested a review from rM-self-serve December 8, 2023 18:41
@Eeems Eeems merged commit 8963569 into testing Dec 10, 2023
3 checks passed
@Eeems Eeems deleted the issue/638 branch December 10, 2023 04:50
Eeems added a commit that referenced this pull request Dec 10, 2023
Eeems added a commit that referenced this pull request Dec 26, 2023
### New Packages
- `webinterface-onboot` 1.2.2-2 - (#770 #721)
  - Allows the usb web interface to start without the USB cable being connected.
- `webinterface-upload-button` - 1.0.1-1 (#771)
  - Adds an upload button to the usb web interface.
- `signature-rm` - 1.0.2-1 (#772)
  - Removes the `Sent from my reMarkable` signature from emails sent by the device.

### Updated Packages
- `linux-stracciatella` - 5.4.70-3 (#742)
  - Updated to RM1XX_5.4.70_v1.3.4 tag from upstream kernel.
  - Added wireguard module.
- `wireguard` - 1.0.20210219-4 (#743 #784)
  - Removed wireguard-tools and wg-quick from wireguard package. These packages are provided by entware already.
- `display` and `rm2fb-client` - 1:0.0.32-2 (#758 #721)
  - Add support for OS 3.3.2.1666
- `rmfm` - 1.5.1-1 (#766)
  - Fix issue where listing a directory with an invalid symlink would crash the application.
- `neofetch` - 1.1.0-1 (#769)
- `webinterface-wifi` - 2.0.0-2 (#768 #721)
- `micro` - 2.0.13-1 (#738)
- `koreader` - 2023.10-2 (#749 #721)
- `ddvk-hacks` - 39.01-2 (#720 #778)
  - Fix issue where `ddvk-hacks` wouldn't be reapplied when using `toltecctl reenable`.
- `draft` - 0.2.0-22 (#721)
- `erode`, `fret`, `oxide`, `rot`, `tarnish`, `decay`, `corrupt`, `anxiety`, `oxide-utils`, `inject_evdev`, and `liboxide` - 2.6-3 (#721)
- `reboot-guard` - 1.0.1-8 (#721)
- `rmfakecloud-proxy` - 0.0.3-4 (#721)
- `genie` - 0.1.6-3 (#721)
- `remux` - 0.2.4-2 (#721)
- `tailscale-systemd` - 0.0.0-2 (#721)
- `toltec-base` - 1.2-3 (#721)
- `xochitl` - 0.0.0-17 (#721)

### Tooling
- New `provides=()` field added for packages.
- Added `unit-exists` and `disable-unit` methods to install-lib

**Note:** This doesn't change what OS version that toltec supports, as full support still requires various packages to be updated, removed, or replaced. Along with proper testing of all packages in the repository, as well as the upgrade process. https://github.com/toltec-dev/toltec/milestone/7 contains the current list of issues and pull requests required for 3.x support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Add or improve packages of the repository tooling Set of scripts and configuration files for building the packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remux prerm script fails on reenable
4 participants