Better bootstrap check-install #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkirwi
reviewed
Jun 29, 2023
bkirwi
previously approved these changes
Jun 29, 2023
Eeems
modified the milestones:
2023-W49 Merge Window,
2023-W50 Merge Window,
2023-W51 Merge Window
|
I just ran this to test it again. It's working as expected. I also added a small guard that verifies that it's being run with |
Jayy001
approved these changes
Jun 2, 2024
|
Example outputs: |
Eeems
added a commit
that referenced
this pull request
Jun 2, 2024
* Update installed check messaging * Add note about unit_path * Error if trying to run with sh or other non-bash shell
Eeems
added a commit
that referenced
this pull request
Jun 4, 2024
### Updated Packages - `appmarkable` - 0.1.3-1 (#876 #875) - `micro` - 2.0.13-2 (#870) - `toltec-bootstrap` - 0.4.4-1 (#704 #690 #873) - `webinterface-upload-button` - 1.1.1-3 (#870) - `open-remarkable-shutdown` - 1.0-3 (#879) - `toltec-deletions` - 0.1-5 (#880) ### Tooling - Fix sha256sum validation (#870).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just had to help someone through reinstalling toltec after a library got corrupted when installing something with nao. One thing I identified is that our current solution for bootstrap checking to see if things are in a partial install state wasn't properly checking to see if /opt is bind mounted still or not. This changes that and provides more context on what it detects when it detects a partial installation.