Suppress reports from unexported interface methods #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an interface method is not exported, its only implementations will be local to the module under analysis. Thus the implementations can be checked, and the caller can assume the error was wrapped. This reasoning does not apply to exported interface methods, even if the interface happens to also have an unexported method. (An implementation can override just the public methods by embedding the interface or a struct that implements it.)
|
Hi @tomarrell, here's the requested PR. It deserves a bit more thought about whether there are untested cases that this will incorrectly ignore. On the bright side, what's there so far is quite simple. |
|
Looks good to me. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an interface method is not exported, its only implementations will be local to the module under analysis. Thus the implementations can be checked, and the caller can assume the error was wrapped.
This reasoning does not apply to exported interface methods, even if the interface happens to also have an unexported method. (An implementation can override just the public methods by embedding the interface or a struct that implements it.)
Resolves #50