Protect against segfault and clean up warnings #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great stuff, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #310 - Segfault appears to be in the TCOD library, it can't handle reversing an empty list in the Dijkstra example finding a path from (0, 0) to (0, 0). Added a protective check around the call the the underlying library. The A* implementation works differently enough to be unaffected from what I can see.
Fixes #297 -
...ranges replaced with..=and unneeded brackets removed. Also updated lazy_static to latest version which resolves a deprecation warning generated from a macro in there.I'll leave this open for a week or so before merging to give chance for comments, none of this seems urgent until the deprecations become breaking.