キーコード自体を最初に入れ替える Keymap 対応 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomoemon
commented
Feb 14, 2025
Comment on lines
+15
to
+20
| keyEventHandler: (evt: InputEvent) => void, | ||
| options?: { | ||
| handleKeyDown?: boolean; | ||
| handleKeyUp?: boolean; | ||
| keyMap?: Map<VirtualKey, VirtualKey>, | ||
| } |
There was a problem hiding this comment.
keyMap を追加するにあたって、onKeyDown + keyMap を指定したい場合にわざわざ onKeyUp に undefined を渡す必要が出てくるため、絶対に必要な keyEventHandler 以外は全部 optional で渡せるようにオブジェクト分割代入形式に変更
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keymap: キーコード to キーコード
KeyboardLayout: キーコード to 英数記号
KeyboardLayout + MozcRule: 英数記号 to キーコード to 文字
Rule: キーコード to 文字
という整理。
配列定義を意味する Rule はすべてキーコードベースで動作する。
一方、Mozc定義では英数記号で配列を定義する。キーコードと英数記号の対応は KeyboardLayout によって決定するので KeyboardLayout によるマッピングが必要。かな系の配列は直接キーコードから文字への対応が行われるので、KeyboardLayout は無くても構わない（とはいえ、通常は英数直接入力への対応が必要なので、KeyboardLayout も必要になる）