-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the statistics of hypothesis testing #135
base: main
Are you sure you want to change the base?
Conversation
Add an option 'test_stat' to display statistics of hypothesis testing (default: False). The statistics are already computed. This option is only displaying.
Thanks for the idea and the PR. A couple suggestions: using the
Works, but the table could use a little cleanup:
There is some redundancy wrt to the Test-stat column. There should only be one test-stat, as p-value is done. Changing
I also don't think the Fisher test is handled appropriately. There really isn't a test stat for it, so it should be blank, but I believe it reports the Chisq's test statistic and the Fisher p-value:
I think t-test, ANOVA, MW, and KW all have test-stats. @tompollard are there any other tests we should worry about. I don't think the mode test is reported like this, so it should be safe. |
Thanks so mush for collaborator's @jraffa and owner's @tompollard help and suggestion. 1.After cleaning up redundancy. There will be one test-stat, as p-value.
2.When pval=False, it will not break.
3.Fisher's test doesn't calculate statistics. The test_stat of Fisher's test is set to None. And the warning message will prompt the users.
[1] Fisher's test did not caompute statistics of hypothesis testing. The following variables are affected: a, b. |
Add an option 'test_stat' to display statistics of hypothesis testing (default: False). The statistics are already computed. This option is only displaying.