Merge pull request #259 from rigomate/fixleaks

Fix memory leaks

src/handler_api.c

@@ -739,6 +739,7 @@ error_t handleApiFileIndex(HttpConnection *connection, const char_t *uri, const
 
         if (queryPrepare(queryString, &rootPath, overlay, sizeof(overlay), &client_ctx->settings) != NO_ERROR)
         {
+            osFreeMem(jsonString);
             return ERROR_FAILURE;
         }
 
@@ -881,6 +882,7 @@ error_t handleApiFileIndex(HttpConnection *connection, const char_t *uri, const
         }
 
         osFreeMem(pathAbsolute);
+        osFreeMem(jsonString);
         jsonString = cJSON_PrintUnformatted(json);
         cJSON_Delete(json);
     } while (0);

src/json_helper.c

@@ -53,7 +53,10 @@ cJSON *jsonAddByteArrayToObject(cJSON *const object, const char *const name, uin
         sprintf(&string[i * 2], "%02hhx", bytes[i]);
     }
 
-    return cJSON_AddStringToObject(object, name, string);
+    // temporary object is needed, so we can free string, because of lack of RAII
+    cJSON *tmpObject = cJSON_AddStringToObject(object, name, string);
+    osFreeMem(string);
+    return tmpObject;
 }
 
 bool_t jsonGetBool(cJSON *jsonElement, char *name)

src/main.c

@@ -222,6 +222,7 @@ void set_settings(const char *option)
     {
         TRACE_ERROR("Invalid config-set option format. Expected name=value.\r\n");
     }
+    osFreeMem(data);
 }
 
 void exit_cleanup(int exit_code)

src/tonie_audio_playlist.c

@@ -189,6 +189,8 @@ error_t tap_generate_taf(tonie_audio_playlist_t *tap, size_t *current_source, bo
         char source[99][PATH_LEN];
         if (tap->filesCount == 0)
         {
+            osFreeMem(tmp_taf);
+            freeTonieInfo(tonieInfo);
             return ERROR_INVALID_FILE;
         }