fix(interactive-processes): stop spinner (#48)

tonik · Dec 5, 2024 · a357704 · a357704
1 parent 3b234ff
commit a357704
Show file tree

Hide file tree

Showing 8 changed files with 31 additions and 5 deletions.
diff --git a/.changeset/dry-stingrays-rhyme.md b/.changeset/dry-stingrays-rhyme.md
@@ -0,0 +1,6 @@
+---
+'stplr-core': patch
+'stplr': patch
+---
+
+Fix interactive auth processes hanging
diff --git a/.changeset/pre.json b/.changeset/pre.json
@@ -15,6 +15,7 @@
     "cuddly-shrimps-cheat",
     "curly-ligers-cheat",
     "curly-pants-fry",
+    "dry-stingrays-rhyme",
     "famous-donkeys-compete",
     "fast-nails-smoke",
     "few-panthers-hammer",

diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -1,5 +1,11 @@
 # stplr
 
+## 0.1.0-alpha.40
+
+### Patch Changes
+
+- Fix interactive auth processes hanging
+
 ## 0.1.0-alpha.39
 
 ### Patch Changes

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "stplr",
-  "version": "0.1.0-alpha.39",
+  "version": "0.1.0-alpha.40",
   "main": "./dist/index.mjs",
   "bin": {
     "stplr": "./dist/index.mjs"

diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md
@@ -1,5 +1,11 @@
 # stplr-core
 
+## 0.2.0-alpha.23
+
+### Patch Changes
+
+- Fix interactive auth processes hanging
+
 ## 0.2.0-alpha.22
 
 ### Patch Changes

diff --git a/packages/core/installMachine/installSteps/github/repositoryManager.ts b/packages/core/installMachine/installSteps/github/repositoryManager.ts
@@ -40,7 +40,11 @@ export const isGitHubAuthenticated = (): boolean => {
 export const authenticateGitHub = async () => {
   await logger.withSpinner('github', 'Attempting to authenticate...', async (spinner) => {
     try {
+      spinner.stop();
+
       execSync('gh auth login', { stdio: 'inherit' });
+
+      spinner.start('Authenticating...');
       const isAuthenticated = isGitHubAuthenticated();
       if (isAuthenticated) {
         spinner.succeed('Authentication successful.');

diff --git a/packages/core/installMachine/installSteps/supabase/loginToSupabase.ts b/packages/core/installMachine/installSteps/supabase/loginToSupabase.ts
@@ -1,5 +1,6 @@
-import { execAsync } from "../../../utils/execAsync";
-import { logger } from "../../../utils/logger";
+import { execSync } from 'child_process';
+import { execAsync } from '../../../utils/execAsync';
+import { logger } from '../../../utils/logger';
 
 export const loginToSupabase = async () => {
   await logger.withSpinner('supabase', 'Logging in...', async (spinner) => {
@@ -8,7 +9,9 @@ export const loginToSupabase = async () => {
       spinner.succeed('Already logged in.');
     } catch (error) {
       try {
-        await execAsync('npx supabase login');
+        spinner.stop();
+        execSync('npx supabase login', { stdio: 'inherit' });
+        spinner.start('Logging in...');
         spinner.succeed('Logged in successfully.');
       } catch {
         spinner.fail('Failed to log in to Supabase.');

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "stplr-core",
-  "version": "0.2.0-alpha.22",
+  "version": "0.2.0-alpha.23",
   "private": true,
   "main": "./dist/index.js",
   "scripts": {