Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an ability to set
server_name
andscript_name
from variables (e.g.:$sent_http_x_pinba_server
, header sent from PHP).Now, before
$pinba_request_uri
it looks atpinba_script_name
, and only if it's empty or failed to parse, it will use variable as fallback.And, now we can customize
server_name
as well (why can't we do that earlier?:)) with similar logic - first, it looks atpinba_server_name
, and if it failed or empty, then it fallback to default.P.S. It was like third time when i wrote C, so maybe i implemented it not the way it should be, but it works :)