Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no change #2

Closed
wants to merge 1 commit into from
Closed

no change #2

wants to merge 1 commit into from

Conversation

tonynajjar
Copy link
Owner

Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)
Does this PR contain AI generated software? (No; Yes and it is marked inline in the code)

Description of contribution in a few bullet points

Description of documentation updates required from your changes

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@tonynajjar tonynajjar closed this Jan 10, 2024
tonynajjar pushed a commit that referenced this pull request Aug 8, 2024
@ahcorde @azeey @SteveMacenski
Initial support to the new Gazebo (ros-navigation#3634)
bc6e3b2 
* Initial support to the new Gazebo

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed build

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feeback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed physics tag

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed physics tag

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fix copyright and urdf

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* min range cannot be zero

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Simplify files

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fix

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Try to reduce load

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed cast shadows

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use Gazebo plugins instead of gz_ros2_control

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* update dependency

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed dependency

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed ros2_control and use ogre

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use param file to configure bridge

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use sdf model and change to ogre instead of ogre2 for sensors

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Support Garden and later, performance improvements

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Use xacro for world file (#2)

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Reviewer feedback

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Add comment explaining temp file

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Fix linter

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Update nav2_bringup/worlds/gz_world_only.sdf.xacro

Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Steve Macenski <[email protected]>
tonynajjar pushed a commit that referenced this pull request Aug 8, 2024
@SteveMacenski @ahcorde @azeey
Migrate TB3 to nav2 minimal turtlebot repository & add the TB4 bringu…
ebe60dc 
…p option for modern gazebo (ros-navigation#4401)

* Initial support to the new Gazebo

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed build

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feeback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed physics tag

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fixed physics tag

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fix copyright and urdf

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* min range cannot be zero

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Simplify files

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Added feedback

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Fix

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Try to reduce load

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed cast shadows

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use Gazebo plugins instead of gz_ros2_control

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* update dependency

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed dependency

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Removed ros2_control and use ogre

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use param file to configure bridge

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Use sdf model and change to ogre instead of ogre2 for sensors

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Support Garden and later, performance improvements

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Use xacro for world file (#2)

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Reviewer feedback

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Add comment explaining temp file

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Fix linter

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Update nav2_bringup/worlds/gz_world_only.sdf.xacro

Co-authored-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>

* port GZ Classic launch changes to modern GZ and remove GZ Classic launch file

* adding changes

* changes done for TB4

* tb3 sim prototype

* fix missing ref

* linting

* fix branch name

* remove assets

* removing refs to turtlebot3_gazebo

* update map

* add new depot map

* Update Nav2 side of multirobot launch files

* linting

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Co-authored-by: Addisu Z. Taddese <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tonynajjar