Rewrite dblstatistics.js to new TopStats API functionality #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xignotic84
reviewed
Oct 28, 2024
jpbberry
reviewed
Oct 28, 2024
lib/index.ts
Outdated
Comment on lines
43
to
51
| approved_at: string; | ||
| /** Current monthly votes */ | ||
| monthly_votes: number; | ||
| /** Current server count */ | ||
| server_count: number; | ||
| /** Total votes received */ | ||
| total_votes: number; | ||
| /** Current shard count */ | ||
| shard_count: number; |
There was a problem hiding this comment.
The mix of camel case and snake case would make the experience inconsistent.
It's my understanding that the API returns snake case but the internal pieces of the library use camel case.
It may be not worth the effort but getting them to be the same throughout the library would make this much nicer. Auto conversion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.