Fix Merge Tree (and Persistence Diagram) barycenter precision #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersistence diagram
|
looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the precision problem of the functions updating the scalars of a barycenter of merge trees (or the special case of persistence diagrams).
The problem was that the new scalar values were computed using double variable, but then returned as a template type variable.
This cast can lead close but different values depending on the computers and this small difference quickly snowballs into bigger and more differences as iterations progress.
C-cast or static_cast can not fix this, so the fix consists in computing the new values directly in the template type instead of double.