This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Review feedback #193
dvdplmci.yml
on: push
Clippy
34s
Rustfmt
13s
Matrix: Bitrot check
Matrix: build
Matrix: test
Matrix: test_no_std
Annotations
23 errors and 36 warnings
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1624
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1624:17
|
1624 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1615
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1615:17
|
1615 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1568
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1568:17
|
1568 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1559
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1559:17
|
1559 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1550
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1550:17
|
1550 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1199
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1199:21
|
1199 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1190
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1190:21
|
1190 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1181
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1181:21
|
1181 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1136
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1136:21
|
1136 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1127
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1127:21
|
1127 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1066
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1066:21
|
1066 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1057
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1057:21
|
1057 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1017
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1017:21
|
1017 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L1008
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:1008:21
|
1008 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L956
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:956:17
|
956 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L947
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:947:17
|
947 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L901
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:901:17
|
901 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L892
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:892:17
|
892 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L883
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:883:17
|
883 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L833
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:833:17
|
833 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L795
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:795:17
|
795 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/sign/signature.rs#L753
error: this expression creates a reference which is immediately dereferenced by the compiler
--> src/sign/signature.rs:753:17
|
753 | &aggregator.signers(),
| ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `aggregator.signers()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
|
Clippy
Clippy had exited with the 101 exit code
|
|
Test on ubuntu-latest
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Bitrot check (stable, ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test on ubuntu-latest
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Bitrot check (stable, ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Bitrot check (stable, ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build target wasm32-unknown-unknown
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Build target wasm32-unknown-unknown
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest (no-std)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test on ubuntu-latest (no-std)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test on ubuntu-latest (no-std)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|