This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Address review concerns from PR 39 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: idiomatic name for getters
Make signers a private member of AggregatorState Make state a private member on SignatureAggregator Prefer returning Result to asserts
Co-authored-by: Hamy Ratoanina <[email protected]>
change: move `dedup_signers` inside `include_signers` change: use `signers()` everywhere change: add a `TooManySigners` error
Nashtare
approved these changes
Apr 15, 2024
Co-authored-by: Robin Salen <[email protected]>
|
@Nashtare Not sure what CI is angry about tbh. :/ |
|
Yeah I've no idea either. I ran all jobs locally so I'll merge as is, and advise if it happens again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #39
main