Skip to content

Commit

Permalink
[FX-NULL] Pass parameter to build-push-release-image (#361)
Browse files Browse the repository at this point in the history
  • Loading branch information
sashuk authored Nov 8, 2024
1 parent 411899c commit 807f43f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/eight-bottles-complain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'davinci-github-actions': major
---

- add `registry-name` mandatory parameter to `build-push-release-image` action
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ Describe the changes and motivations for the pull request, unless evident from t

List of available commands:

- `@toptal-anvil ping reviewers` - Ping FX team for review
- `@toptal-anvil ping reviewers` - Ping teams for review

</details>
1 change: 1 addition & 0 deletions build-push-release-image/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ The list of arguments, that are used in GH Action:
| name | type | required | default | description |
| ----------------------- | ----------------------------------------------------------- | -------- | ------- | ------------------------------------------------------------------------------------------------------------------- |
| `sha` | string || | Commit hash that will be used as a tag for the Docker image |
| `registry-name` | string || | Name of registry |
| `repository-name` | string || | Name of repository. It's used to determine an image name |
| `environment` | enum<<br/>`temploy`,<br/>`staging`,<br/>`production`,<br/>> | | staging | Used to determine additional procedures while creating a Docker image |
| `dist-folder` | string | | ./dist | Path to the folder with the built project |
Expand Down
4 changes: 4 additions & 0 deletions build-push-release-image/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ inputs:
sha:
required: true
description: Commit hash that will be used as a tag for the Docker image
registry-name:
required: true
description: Name of registry
repository-name:
required: true
description: Name of repository. It's used to determine an image name
Expand Down Expand Up @@ -52,6 +55,7 @@ runs:
- uses: toptal/davinci-github-actions/[email protected]
with:
sha: ${{ inputs.sha }}
registry-name: ${{ inputs.registry-name }}
image-name: ${{ inputs.repository-name }}-release
environment: ${{ inputs.environment }}
node-version: ${{ inputs.node-version }}
Expand Down

0 comments on commit 807f43f

Please sign in to comment.