[FX-NULL] Add gh-runners-driver-opts option #356
Conversation
🦋 Changeset detectedLatest commit: 7e822d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
catks
changed the title
sashuk
force-pushed
the
case-fix-build-push-docker-rate-limit
branch
from
57ce269
to
7e822d6
Compare
| @@ -61,6 +61,9 @@ inputs: | |||
| registry-name: | |||
| required: true | |||
| description: 'Registry to push the builded image' | |||
| gh-runner-driver-opts: | |||
| required: false | |||
| description: 'Driver options for GH Runners' | |||
There was a problem hiding this comment.
@catks I deleted the default value that you initially provided to allow docker/setup-buildx-action be more flexible, is it okay? I can image that docker/setup-buildx-action updates tomorrow and starts using another default value (and this affects us as we use major version tag v3) we will have to update the default value here as well to keep up.
There was a problem hiding this comment.
Sounds good, but note it will cause a problem if anyone uses the action with the master branch as we are introducing a new required input in this case
sashuk
changed the title
sashuk
changed the title
sashuk
requested review from
a team and
denieler
and removed request for
a team
|
@toptal-anvil ping reviewers |
Description
Add
gh-runners-driver-optsinput in build-push action.We can use a custom image to avou DockerHub Rate limit errors like:
Fix Error: ERROR: Error response from daemon: No such image: moby/buildkit:buildx-stable-1/ERROR: Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limitHow to test
Development checks
PR commands
List of available commands:
@toptal-anvil ping reviewers- Ping FX team for review