Upgrade to actions/upload-artifact@v4; fix testing matrix
#415
+16
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerolab
reviewed
Feb 6, 2025
tests/requirements.txt
Outdated
| @@ -4,7 +4,7 @@ ruff==0.0.287 | |||
|
|
|||
| # Runtime requirements | |||
| Django>=4.2,<5.1 | |||
| wagtail>=4.1 | |||
| wagtail>=6.2,<6.3 | |||
There was a problem hiding this comment.
Suggested change
| wagtail>=6.2,<6.3 | |
| wagtail>=5.2,<6.3 |
allthough I would even go as far as <6.5
There was a problem hiding this comment.
Yes, I noticed that tox has its own list of Wagtail versions. I'm not sure why that was failing locally; I'll keep digging. But I think Wagtail 6.4 fails the tests because of the migration issue that I was addressing in #414.
mgax
force-pushed
the
fix/ci-upload-artifact-v4
branch
from
c35f840 to
fdfd1f3
Compare
mgax
commented
Feb 6, 2025
mgax
commented
Feb 6, 2025
|
It turns out that our pipeline wasn't checking older Wagtail versions. It only works against Wagtail 6.2 at the moment. I suggest we merge this PR to fix the pipeline. |
zerolab
reviewed
Feb 6, 2025
mgax
changed the title
actions/upload-artifact@v4actions/upload-artifact@v4; fix testing matrix
zerolab
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI runs are failing with this error:
I've upgraded to v4 of the
upload-artifactanddownload-artifactactions: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md.One change that affects this repository is about "Multiple uploads to the same named Artifact"; the uploads need to have distinct names, and then get merged during download.