Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redirect to events page if event is not found #50

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Redirect to events page if event is not found #50

merged 2 commits into from
Oct 2, 2024

Conversation

marcoroth
Copy link
Contributor

Fixes #49

@crespire
Copy link
Contributor

crespire commented Oct 2, 2024

@marcoroth let me know when this is ready for review, looks good though from a cursory look over!

@marcoroth
Copy link
Contributor Author

@crespire this should be ready as-is!

@crespire crespire merged commit 61e45ae into toronto-ruby:main Oct 2, 2024
1 check passed
@crespire
Copy link
Contributor

crespire commented Oct 2, 2024

@crespire this should be ready as-is!

Thanks again for your contributions!

@marcoroth marcoroth deleted the dont-fail-on-unknown-events branch October 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespire crespire crespire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Event show is broken when a non-resolvable ID is passed in
2 participants
@marcoroth @crespire