-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
udp: symmetric encrypted cookie #1091
Conversation
97e96c7
to
91d1dc0
Compare
91d1dc0
to
be5fb95
Compare
be5fb95
to
b5983d4
Compare
b5983d4
to
25d354f
Compare
25d354f
to
eddf231
Compare
eddf231
to
356f652
Compare
356f652
to
e5ba2cd
Compare
e5ba2cd
to
a60571c
Compare
a60571c
to
41582ac
Compare
41582ac
to
39ccba7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1091 +/- ##
===========================================
- Coverage 77.14% 76.44% -0.70%
===========================================
Files 174 174
Lines 11750 11488 -262
Branches 11750 11488 -262
===========================================
- Hits 9064 8782 -282
- Misses 2488 2507 +19
- Partials 198 199 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
39ccba7
to
b683b8c
Compare
b683b8c
to
e3562f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @da2ce7 It looks good to me. I have only added some minor suggestions.
Regarding performance, it seems it hasn't changed.
This PR
Worst case:
Requests out: 425928.00/second
Responses in: 403889.28/second
- Connect responses: 199933.64
- Announce responses: 199936.23
- Scrape responses: 4019.41
- Error responses: 0.00
Peers per announce response: 0.00
Announce responses per info hash:
- p10: 1
- p25: 1
- p50: 1
- p75: 1
- p90: 2
- p95: 3
- p99: 105
- p99.9: 323
- p100: 407
Best case:
Requests out: 492705.64/second
Responses in: 415447.68/second
- Connect responses: 205609.94
- Announce responses: 205718.08
- Scrape responses: 4119.67
- Error responses: 0.00
Peers per announce response: 0.00
Announce responses per info hash:
- p10: 1
- p25: 1
- p50: 1
- p75: 1
- p90: 2
- p95: 3
- p99: 105
- p99.9: 331
- p100: 429
Base branch
Worst case:
Requests out: 416133.96/second
Responses in: 379643.54/second
- Connect responses: 188013.86
- Announce responses: 187883.50
- Scrape responses: 3745.38
- Error responses: 0.80
Peers per announce response: 0.00
Announce responses per info hash:
- p10: 1
- p25: 1
- p50: 1
- p75: 1
- p90: 2
- p95: 3
- p99: 104
- p99.9: 305
- p100: 389
Best case:
Requests out: 539571.74/second
Responses in: 448536.20/second
- Connect responses: 222046.78
- Announce responses: 222037.22
- Scrape responses: 4452.20
- Error responses: 0.00
Peers per announce response: 0.00
Announce responses per info hash:
- p10: 1
- p25: 1
- p50: 1
- p75: 1
- p90: 2
- p95: 3
- p99: 104
- p99.9: 353
- p100: 455
NOTE: this best case is not common.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @da2ce7 some tests are not passing after these latest changes.
a5e8796
to
c53e289
Compare
ACK c53e289 |
Implement a simple symmetrically encrypted connection id to be used as a cookie for authenticating announce requests.
I have taken some time to optimize the implementation, hopefully it will preform the same as the previous approach.