Overhaul core Tracker: extract stats #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the core tracker This is part of a big refactor. We are extracting responsabilities from the tracker. The first step is to inject the service into the tracker and later we will use the extracted services directly. Finally we will removed the injected service from the tracker when it's not used anymore via the tracker.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1186 +/- ##
===========================================
+ Coverage 76.54% 77.19% +0.65%
===========================================
Files 181 181
Lines 12002 12393 +391
Branches 12002 12393 +391
===========================================
+ Hits 9187 9567 +380
- Misses 2648 2659 +11
Partials 167 167 ☔ View full report in Codecov by Sentry. |
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
5c6045b to
a22868d
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
a22868d to
f2ada4c
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
f2ada4c to
fc78ac8
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
fc78ac8 to
ee5527d
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
ee5527d to
ffafa5b
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
ffafa5b to
4026983
Compare
josecelano
force-pushed
the
1184-overhaul-core-tracker-extract-stats
branch
from
4026983 to
2a0bc47
Compare
|
ACK 2a0bc47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhaul core Tracker: extract stats