Overhaul core Tracker: review whitelist functionality

[josecelano]

Overhaul core Tracker: review whitelist functionality.

Sub-tasks

• Introduce submodules for handlers in UDP: servers::udp::handlers::{announce, scrape}.
• Create the missing services (app layer) in the UDP tracker. There is no intermediary level between handlers and the core tracker. It will moved to its own package udp-tracker-core later.
• Move the service services::announce::invoke() in the HTTP tracker to the http-tracker-core package.
• Move the service services::announce::invoke() in the UDP tracker to the udp-tracker-core package.
• Move logic from the handler (in the framework level - delivery layer) to the application service in the http-tracker-core package.
  • For the announce request
  • For the scrape request
• Move logic from the handler (controller level - delivery layer) to the application service in the udp-tracker-core package.
  • For the announce request
  • For the scrape request
• Add version module also for the UDP tracker. I don't see any reason to use v1 in the http tracker but not in the UDP tracker. I will leave this until we introduce a new major version.

Sub-tasks for a new PR

I've left these tasks for a new issue. This PR is just moving things and the new tasks imply changing function signatures.

• In the tracker-core announce handler return a Result<AnnounceData, AnnounceError> when the torrent is not included in the whitelist.
• In the tracker-core scrape handler return a Result<ScrapeData, ScrapeError> so we are able to return errors in the future without breaking the public API.

[codecov]

Codecov Report

Attention: Patch coverage is 97.77247% with 28 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (2f505a8) to head (eca5c59).
Report is 10 commits behind head on develop.

Files with missing lines	Patch %	Lines
src/servers/udp/handlers/announce.rs	96.37%	20 Missing and 2 partials ⚠️
packages/http-protocol/src/v1/requests/announce.rs	89.47%	2 Missing ⚠️
src/servers/udp/handlers/scrape.rs	99.17%	2 Missing ⚠️
...rc/packages/http_tracker_core/services/announce.rs	96.66%	1 Missing ⚠️
src/packages/udp_tracker_core/services/announce.rs	97.82%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1269      +/-   ##
===========================================
+ Coverage    80.97%   81.23%   +0.25%     
===========================================
  Files          207      212       +5     
  Lines        14762    14891     +129     
  Branches     14762    14891     +129     
===========================================
+ Hits         11954    12096     +142     
+ Misses        2610     2604       -6     
+ Partials       198      191       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[josecelano]

I cant' move the authentication functionality to the http_tracker_core and udp_tracker_core yet because it forces me to move other stuff and that's out of the scope of this PR. I will do it when I extract the packages.

[josecelano]

ACK eca5c59