This repository has been archived by the owner on Oct 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
add megalinter and update dependencies #204
Open
grmbyrn
wants to merge
5
commits into
torrust:develop
Choose a base branch
from
grmbyrn:dependencies
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"ignorePaths": [ | ||
"**/node_modules/**", | ||
"**/vscode-extension/**", | ||
"**/.git/**", | ||
"**/.pnpm-lock.json", | ||
".vscode", | ||
"megalinter", | ||
"package-lock.json", | ||
"report" | ||
], | ||
"language": "en", | ||
"noConfigSearch": true, | ||
"words": ["megalinter", "oxsecurity"], | ||
"version": "0.2" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,185 @@ | ||
# MegaLinter GitHub Action configuration file | ||
# More info at https://megalinter.io | ||
--- | ||
name: MegaLinter | ||
|
||
# Trigger mega-linter at every push. Action will also be visible from | ||
# Pull Requests to main | ||
on: | ||
# Comment this line to trigger action only on pull-requests | ||
# (not recommended if you don't pay for GH Actions) | ||
push: | ||
|
||
pull_request: | ||
branches: | ||
- main | ||
- master | ||
- develop | ||
|
||
# Comment env block if you do not want to apply fixes | ||
env: | ||
# Apply linter fixes configuration | ||
# | ||
# When active, APPLY_FIXES must also be defined as environment variable | ||
# (in github/workflows/mega-linter.yml or other CI tool) | ||
APPLY_FIXES: all | ||
|
||
# Decide which event triggers application of fixes in a commit or a PR | ||
# (pull_request, push, all) | ||
APPLY_FIXES_EVENT: pull_request | ||
|
||
# If APPLY_FIXES is used, defines if the fixes are directly committed (commit) | ||
# or posted in a PR (pull_request) | ||
APPLY_FIXES_MODE: commit | ||
|
||
concurrency: | ||
group: ${{ github.ref }}-${{ github.workflow }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
megalinter: | ||
name: MegaLinter | ||
runs-on: ubuntu-latest | ||
|
||
# Give the default GITHUB_TOKEN write permission to commit and push, comment | ||
# issues, and post new Pull Requests; remove the ones you do not need | ||
permissions: | ||
contents: write | ||
issues: write | ||
pull-requests: write | ||
|
||
steps: | ||
# Git Checkout | ||
- name: Checkout Code | ||
uses: actions/checkout@v4 | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# If you use VALIDATE_ALL_CODEBASE = true, you can remove this line to | ||
# improve performance | ||
fetch-depth: 0 | ||
|
||
# MegaLinter | ||
- name: MegaLinter | ||
|
||
# You can override MegaLinter flavor used to have faster performances | ||
# More info at https://megalinter.io/latest/flavors/ | ||
uses: oxsecurity/megalinter/flavors/javascript@v7 | ||
|
||
id: ml | ||
|
||
# All available variables are described in documentation | ||
# https://megalinter.io/latest/config-file/ | ||
env: | ||
# Validates all source when push on main, else just the git diff with | ||
# main. Override with true if you always want to lint all sources | ||
# | ||
# To validate the entire codebase, set to: | ||
# VALIDATE_ALL_CODEBASE: true | ||
# | ||
# To validate only diff with main, set to: | ||
# VALIDATE_ALL_CODEBASE: >- | ||
# ${{ | ||
# github.event_name == 'push' && | ||
# github.ref == 'refs/heads/main' | ||
# }} | ||
VALIDATE_ALL_CODEBASE: true | ||
|
||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
|
||
# ADD YOUR CUSTOM ENV VARIABLES HERE TO OVERRIDE VALUES OF | ||
# .mega-linter.yml AT THE ROOT OF YOUR REPOSITORY | ||
|
||
# Upload MegaLinter artifacts | ||
- name: Archive production artifacts | ||
uses: actions/upload-artifact@v4 | ||
if: success() || failure() | ||
with: | ||
name: MegaLinter reports | ||
path: | | ||
megalinter-reports | ||
mega-linter.log | ||
|
||
# Create pull request if applicable | ||
# (for now works only on PR from same repository, not from forks) | ||
- name: Create Pull Request with applied fixes | ||
uses: peter-evans/create-pull-request@v6 | ||
id: cpr | ||
if: >- | ||
steps.ml.outputs.has_updated_sources == 1 && | ||
( | ||
env.APPLY_FIXES_EVENT == 'all' || | ||
env.APPLY_FIXES_EVENT == github.event_name | ||
) && | ||
env.APPLY_FIXES_MODE == 'pull_request' && | ||
( | ||
github.event_name == 'push' || | ||
github.event.pull_request.head.repo.full_name == github.repository | ||
) && | ||
!contains(github.event.head_commit.message, 'skip fix') | ||
with: | ||
token: ${{ secrets.GITHUB_TOKEN }} | ||
commit-message: '[MegaLinter] Apply linters automatic fixes' | ||
title: '[MegaLinter] Apply linters automatic fixes' | ||
labels: bot | ||
|
||
- name: Create PR output | ||
if: >- | ||
steps.ml.outputs.has_updated_sources == 1 && | ||
( | ||
env.APPLY_FIXES_EVENT == 'all' || | ||
env.APPLY_FIXES_EVENT == github.event_name | ||
) && | ||
env.APPLY_FIXES_MODE == 'pull_request' && | ||
( | ||
github.event_name == 'push' || | ||
github.event.pull_request.head.repo.full_name == github.repository | ||
) && | ||
!contains(github.event.head_commit.message, 'skip fix') | ||
run: | | ||
echo "PR Number - ${{ steps.cpr.outputs.pull-request-number }}" | ||
echo "PR URL - ${{ steps.cpr.outputs.pull-request-url }}" | ||
|
||
# Push new commit if applicable | ||
# (for now works only on PR from same repository, not from forks) | ||
- name: Prepare commit | ||
if: >- | ||
steps.ml.outputs.has_updated_sources == 1 && | ||
( | ||
env.APPLY_FIXES_EVENT == 'all' || | ||
env.APPLY_FIXES_EVENT == github.event_name | ||
) && | ||
env.APPLY_FIXES_MODE == 'commit' && | ||
github.ref != 'refs/heads/main' && | ||
( | ||
github.event_name == 'push' || | ||
github.event.pull_request.head.repo.full_name == github.repository | ||
) && | ||
!contains(github.event.head_commit.message, 'skip fix') | ||
run: sudo chown -Rc $UID .git/ | ||
|
||
- name: Commit and push applied linter fixes | ||
uses: stefanzweifel/git-auto-commit-action@v5 | ||
if: >- | ||
steps.ml.outputs.has_updated_sources == 1 && | ||
( | ||
env.APPLY_FIXES_EVENT == 'all' || | ||
env.APPLY_FIXES_EVENT == github.event_name | ||
) && | ||
env.APPLY_FIXES_MODE == 'commit' && | ||
github.ref != 'refs/heads/main' && | ||
( | ||
github.event_name == 'push' || | ||
github.event.pull_request.head.repo.full_name == github.repository | ||
) && | ||
!contains(github.event.head_commit.message, 'skip fix') | ||
with: | ||
branch: >- | ||
${{ | ||
github.event.pull_request.head.ref || | ||
github.head_ref || | ||
github.ref | ||
}} | ||
commit_message: '[MegaLinter] Apply linters fixes' | ||
commit_user_name: megalinter-bot | ||
commit_user_email: [email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,3 +15,5 @@ node_modules | |
vite.config.js.timestamp-* | ||
vite.config.ts.timestamp-* | ||
yarn.lock | ||
|
||
megalinter-reports/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
# Configuration file for MegaLinter | ||
# | ||
# See all available variables at https://megalinter.io/latest/config-file/ and in | ||
# linters documentation | ||
|
||
# all, none, or list of linter keys | ||
APPLY_FIXES: all | ||
|
||
# If you use ENABLE variable, all other languages/formats/tooling-formats will | ||
# be disabled by default | ||
# ENABLE: | ||
|
||
# If you use ENABLE_LINTERS variable, all other linters will be disabled by | ||
# default | ||
# ENABLE_LINTERS: | ||
|
||
DISABLE: | ||
- COPYPASTE # Comment to enable checks of excessive copy-pastes | ||
# - SPELL # Uncomment to disable checks of spelling mistakes | ||
|
||
SHOW_ELAPSED_TIME: true | ||
|
||
FILEIO_REPORTER: false | ||
# Uncomment if you want MegaLinter to detect errors but not block CI to pass | ||
# DISABLE_ERRORS: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @grmbyrn why did you remove the environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @josecelano
github-pages
was giving me this error:I asked ChatGPT for advice and it recommended removing the environment as it's not necessary for deploying to GitHub Pages. It said that if you want to specify an environment, you can define it separately and reference it within your workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The environment exists:
Sometimes I also get those warnings, but the env name could be whatever you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so do you recommend putting the environment back and ignoring the error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @josecelano I've been looking for a solution to this and found an issue on GitHub Actions repo from May about including
github-pages
as a valid option. It's currently been placed in the backlog of projects. Do you think it's okay to put it back in and ignore the error?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, @graeme, I would put it back, and I would open a new issue to inform other contributors they could have that error until that schema is updated. We can close it when it is updated, since I think we can't do anything else.