fix: removed reduntant channel for telegram handler

torusresearch · Feb 4, 2025 · 4c14719 · 4c14719
1 parent f97c776
commit 4c14719
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 17 deletions.
diff --git a/examples/vue-app/src/App.vue b/examples/vue-app/src/App.vue
@@ -292,7 +292,6 @@ const loginToConnectionMap = computed((): Record<string, Record<string, string |
     [REDDIT]: { domain: AUTH_DOMAIN, connection: "Reddit", verifierIdField: "name", isVerifierIdCaseSensitive: false },
     [TELEGRAM]: {
         identity_provider: "Telegram",
-        domain: "https://oauth.tg.dev/auth",
         origin: "https://custom-auth-beta.vercel.app/serviceworker/redirect",
     },
     [WEB3AUTH_EMAIL_PASSWORDLESS]: {

diff --git a/src/handlers/TelegramHandler.ts b/src/handlers/TelegramHandler.ts
@@ -2,7 +2,7 @@ import base64url from "base64url";
 import deepmerge from "deepmerge";
 
 import { UX_MODE } from "../utils/enums";
-import { broadcastChannelOptions, getTimeout, objectToAuthDataMap, validateAndConstructUrl } from "../utils/helpers";
+import { getTimeout, objectToAuthDataMap, validateAndConstructUrl } from "../utils/helpers";
 import log from "../utils/loglevel";
 import PopupHandler from "../utils/PopupHandler";
 import AbstractLoginHandler from "./AbstractLoginHandler";
@@ -79,7 +79,6 @@ export default class TelegramHandler extends AbstractLoginHandler {
     if (this.params.uxMode === UX_MODE.REDIRECT) {
       verifierWindow.redirect(params.locationReplaceOnRedirect);
     } else {
-      const { BroadcastChannel } = await import("@toruslabs/broadcast-channel");
       return new Promise<LoginWindowResponse>((resolve, reject) => {
         // eslint-disable-next-line @typescript-eslint/no-explicit-any
         let bc: any;
@@ -107,27 +106,21 @@ export default class TelegramHandler extends AbstractLoginHandler {
           }
         };
 
-        if (!this.params.redirectToOpener) {
-          bc = new BroadcastChannel<{
-            error: string;
-            data: PopupResponse;
-          }>(`redirect_channel_${this.nonce}`, broadcastChannelOptions);
-          bc.addEventListener("message", async (ev: string) => {
-            await handleData(ev);
-            bc.close();
-            verifierWindow.close();
-          });
-        }
         const postMessageEventHandler = async (postMessageEvent: MessageEvent) => {
-          if (!postMessageEvent.data) return;
+          if (!postMessageEvent.data) {
+            throw new Error("Invalid data received");
+          }
+          if (this.finalURL.origin !== postMessageEvent.origin) {
+            throw new Error("Invalid origin received");
+          }
           // make sure event is auth_result from telegram
           const ev = postMessageEvent.data;
           if (typeof ev != "string") {
-            return;
+            throw new Error("Invalid data type received");
           }
           const { event } = (JSON.parse(ev) as PopupResponse) || {};
           if (event && event !== "auth_result") {
-            return;
+            throw new Error("Invalid event received");
           }
           window.removeEventListener("message", postMessageEventHandler);
           handleData(ev);