Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomAuth refactor #357

Merged
merged 1 commit into from
Aug 29, 2024
Merged

CustomAuth refactor #357

merged 1 commit into from
Aug 29, 2024

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Aug 28, 2024

Motivation and Context

  • remove hybrid aggregate login method
  • refactor customauth params
    Jira Link:

Description

Removes hybrid aggregate login method
removes reddit login type since it's deprecated by reddit
update facebook to v20 api
refactor customauth createhandler api
simplify handlers

How has this been tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- remove hybrid aggregate login method
@chaitanyapotti chaitanyapotti changed the title - refactor customauth params CustomAuth refactor Aug 28, 2024
Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit be8d8de into master Aug 29, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/refactor branch August 29, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants