fix: comment

redundance function
torusresearch · Feb 25, 2025 · 270a36c · 270a36c
1 parent e1431dc
commit 270a36c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 27 deletions.
diff --git a/src/helpers/common.ts b/src/helpers/common.ts
@@ -16,11 +16,14 @@ export const generatePrivateKey = (ecCurve: EC, buf: typeof Buffer): Buffer => {
   return ecCurve.genKeyPair().getPrivate().toArrayLike(buf);
 };
 
+const secp256k1EC = new EC("secp256k1");
+const ed25519EC = new EC("ed25519");
+
 export const getKeyCurve = (keyType: KeyType) => {
-  if (keyType === KEY_TYPE.ED25519) {
-    return new EC(KEY_TYPE.ED25519);
-  } else if (keyType === KEY_TYPE.SECP256K1) {
-    return new EC(KEY_TYPE.SECP256K1);
+  if (keyType === KEY_TYPE.SECP256K1) {
+    return secp256k1EC;
+  } else if (keyType === KEY_TYPE.ED25519) {
+    return ed25519EC;
   }
   throw new Error(`Invalid keyType: ${keyType}`);
 };

diff --git a/src/helpers/keyUtils.ts b/src/helpers/keyUtils.ts
@@ -13,26 +13,6 @@ import { encParamsBufToHex, generatePrivateKey, getKeyCurve, keccak256 } from ".
 import { generateRandomPolynomial } from "./langrangeInterpolatePoly";
 import { generateNonceMetadataParams, getSecpKeyFromEd25519 } from "./metadataUtils";
 
-const secp256k1EC = new EC("secp256k1");
-const ed25519EC = new EC("ed25519");
-
-/**
- * Returns the correct elliptic curve for the given keyType.
- *
- * @param keyType - The key type to get the curve for.
- * @throws \{Error\} If the keyType is not valid.
- * @returns \{EC\} The elliptic curve.
- *
- */
-export const getEcCurve = (keyType: KeyType): EC => {
-  if (keyType === KEY_TYPE.SECP256K1) {
-    return secp256k1EC;
-  } else if (keyType === KEY_TYPE.ED25519) {
-    return ed25519EC;
-  }
-  throw new Error(`Invalid keyType: ${keyType}`);
-};
-
 export function stripHexPrefix(str: string): string {
   return str.startsWith("0x") ? str.slice(2) : str;
 }

diff --git a/src/torus.ts b/src/torus.ts
@@ -16,8 +16,8 @@ import {
   encodeEd25519Point,
   generateAddressFromPubKey,
   generateShares,
-  getEcCurve,
   getEd25519ExtendedPublicKey,
+  getKeyCurve,
   getMetadata,
   getOrSetNonce,
   GetOrSetNonceError,
@@ -269,7 +269,7 @@ class Torus {
     enableOneKey: boolean
   ): Promise<TorusPublicKey> {
     const localKeyType = keyType ?? this.keyType;
-    const localEc = getEcCurve(localKeyType);
+    const localEc = getKeyCurve(localKeyType);
 
     const keyAssignResult = await GetPubKeyOrKeyAssign({
       endpoints,
@@ -375,7 +375,7 @@ class Torus {
   }): Promise<TorusPublicKey> {
     const { finalKeyResult, enableOneKey, isNewKey, serverTimeOffset, keyType } = params;
     const localKeyType = keyType ?? this.keyType;
-    const localEc = getEcCurve(localKeyType);
+    const localEc = getKeyCurve(localKeyType);
 
     const { pub_key_X: X, pub_key_Y: Y } = finalKeyResult.keys[0];
     let nonceResult: GetOrSetNonceResult;