Harmonize dependencies against NET 8 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* drop NET 6 support which is EOL * make 8.0.x series default minimal * don't require System.Text.Json when it's built-in
|
Appveyor seems to be a bit of a lost cause, but I fixed GH actions to run correctly by checking NET 9 SDK installation before build. |
|
Build looking good with the changes, if looks reasonable, a nuget release would be great (with symbols from the GH action) 🙏🏻
|
totpero
approved these changes
Dec 4, 2024
|
Hi @lahma , |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NET 9.x libraries are quite aggressive and can cause concern when consumed from NET 8 (LTS). Downgrading to 8.x and allowing consumers to upgrade with their own dependencies to later version.
I would also argue whether NET 9 target is really necessary when NET 8 is already there and now NET 9 functionality is being used (via pre-processor directives etc). NET 8 binaries will run on NET 9 just fine.