Add Wasm support #374
Merged
Add Wasm support #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhill303
reviewed
Oct 6, 2023
samhill303
reviewed
Oct 6, 2023
russhwolf
reviewed
Oct 6, 2023
| @@ -10,7 +10,7 @@ jobs: | |||
| build: | |||
| strategy: | |||
| matrix: | |||
| os: [macOS-latest, windows-latest] | |||
There was a problem hiding this comment.
I'm a little uncomfortable turning this off but I'm also not clear anymore what this was originally doing, since there's very little windows-specific code.
There was a problem hiding this comment.
It's temporary for this PR to pass the checks. There is PR open to re-enable it #375
kermit-core/src/darwinTest/wasmMain/kotlin/co/touchlab/kermit/Js.ConsoleActual.kt
Outdated
Show resolved
Hide resolved
samhill303
approved these changes
Oct 10, 2023
russhwolf
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #362
jsWasmMain/TestsourceSet and pointed bothjsandwasmto depend on thatwasm-browsersample app (check screenshot below)Sample browser console screenshot