Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update GitHub Actions CI #740

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: update GitHub Actions CI #740

merged 1 commit into from
Jul 23, 2024

Conversation

striezel
Copy link
Contributor

@striezel striezel commented Jun 10, 2023

The following updates are performed:

Still using the outdated / unmaintained actions will generate several warnings in CI runs, for example in https://github.com/tower-rs/tower/actions/runs/4995991400:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

The PR will get rid of those warnings.

Copy link
Contributor

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
wasn't aware of this change in the ecosystem,
but double checking docs at https://github.com/dtolnay/rust-toolchain and other info I found seems to back the incentive behind this PR.

@striezel
Copy link
Contributor Author

wasn't aware of this change in the ecosystem, but double checking docs at https://github.com/dtolnay/rust-toolchain and other info I found seems to back the incentive behind this PR.

In the mean time, the whole actions-rs organization has been archived. If the lack of maintainer activity in the repos over there was not enough of a hint that nothing is going to happen there anymore, then that step finally settled it for good.

So yeah ... I think everyone who is still using actions-rs/toolchain etc. should move to an alternative as soon as possible.

@striezel
Copy link
Contributor Author

@hawkw @GlenDC Any updates on this one? Looks like some of the checks have not even started yet, so I guess that maybe someone has to approve them in order for them to run?

@tobz tobz added T-ci Topic: continuous integration C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jul 20, 2024
@GlenDC
Copy link
Contributor

GlenDC commented Jul 22, 2024

@tobz this is also a trivial one to merge, no? Or am I missing something?

@tobz
Copy link
Member

tobz commented Jul 22, 2024

Yeah, this is probably fine to merge as-is... although it's another case where the PR branch is out-of-date and I can't trivially update it.

The following updates are performed:
* update actions/checkout to v4
* replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain
* replace unmaintained actions-rs/cargo by direct invocation of cargo
@striezel
Copy link
Contributor Author

although it's another case where the PR branch is out-of-date and I can't trivially update it.

It's been over a year, so that's no surprise. I almost got the impression the project had been abandoned due to the lack of activity here.

Anyway, I rebased the branch against the current master so this should be easier to merge now.

@tobz tobz merged commit a6e98a7 into tower-rs:master Jul 23, 2024
14 checks passed
@striezel striezel deleted the ci-actions-update branch July 23, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-ci Topic: continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants