-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update GitHub Actions CI #740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wasn't aware of this change in the ecosystem,
but double checking docs at https://github.com/dtolnay/rust-toolchain and other info I found seems to back the incentive behind this PR.
In the mean time, the whole actions-rs organization has been archived. If the lack of maintainer activity in the repos over there was not enough of a hint that nothing is going to happen there anymore, then that step finally settled it for good. So yeah ... I think everyone who is still using |
@tobz this is also a trivial one to merge, no? Or am I missing something? |
Yeah, this is probably fine to merge as-is... although it's another case where the PR branch is out-of-date and I can't trivially update it. |
The following updates are performed: * update actions/checkout to v4 * replace unmaintained actions-rs/toolchain by dtolnay/rust-toolchain * replace unmaintained actions-rs/cargo by direct invocation of cargo
It's been over a year, so that's no surprise. I almost got the impression the project had been abandoned due to the lack of activity here. Anyway, I rebased the branch against the current |
The following updates are performed:
actions/checkout
to v4actions-rs/toolchain
bydtolnay/rust-toolchain
actions-rs/cargo
by direct invocation ofcargo
Still using the outdated / unmaintained actions will generate several warnings in CI runs, for example in https://github.com/tower-rs/tower/actions/runs/4995991400:
The PR will get rid of those warnings.