Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix grammar #749

Merged
merged 3 commits into from
Nov 6, 2023
Merged

docs: fix grammar #749

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0d96215
docs: fix grammar
EricCrosson Oct 29, 2023
e3b9d88
Apply suggestions from code review
hawkw Nov 6, 2023
6fbe344
Merge branch 'master' into docs-fix-grammar
hawkw Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions guides/building-a-middleware-from-scratch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ where
type Future = S::Future;

fn poll_ready(&mut self, cx: &mut Context<'_>) -> Poll<Result<(), Self::Error>> {
// Our middleware doesn't care about backpressure so its ready as long
// Our middleware doesn't care about backpressure, so it's ready as long
// as the inner service is ready.
self.inner.poll_ready(cx)
}
Expand Down Expand Up @@ -192,9 +192,9 @@ where

Ideally we want to write something like this:

1. First poll `self.response_future` and if its ready return the response or error it
1. First poll `self.response_future`, and if it's ready, return the response or error it
resolved to.
2. Otherwise poll `self.sleep` and if its ready return an error.
2. Otherwise, poll `self.sleep`, and if it's ready, return an error.
3. If neither future is ready return `Poll::Pending`.

We might try:
Expand Down
Loading