add ServiceBuilder::boxed_clone_sync helper #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlizen
force-pushed
the
master
branch
3 times, most recently
from
8bd56ed to
ac861f9
Compare
|
This is a quickie if you have a minute @seanmonstar , you have context on this from #777 |
seanmonstar
reviewed
Dec 20, 2024
seanmonstar
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in: #777
Adding the
ServiceBuilder::boxed_clone_sync()method to matchboxed_cloneandboxed().Note that in this case, I used the named,
BoxCloneSyncServiceLayer, rather than the layer fn returned byBoxedCloneSyncService::layer(). I don't really see a good reason to prefer the latter. I think the reason that other helpers use that, is historical (named layer didn't exist yet).Probably we should migrate everything over, but that seems likely to be a breaking change so I held off. Glad to cut an issue on that if you concur.
The only testing was via a doctest. This matches the other helper.