chore: ensure keys and values have same size

Refs: nodejs#54213 (comment)
tpoisseau · Aug 28, 2024 · 41cdbd7 · 41cdbd7
1 parent d0c8655
commit 41cdbd7
Showing 1 changed file with 11 additions and 7 deletions.
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
@@ -528,8 +528,9 @@ void StatementSync::IterateReturnCallback(
   LocalVector<Value> values(isolate,
                             {Boolean::New(isolate, true), Null(isolate)});
 
-  Local<Object> result =
-      Object::New(isolate, Null(isolate), keys.data(), values.data(), 2);
+  DCHECK_EQ(keys.size(), values.size());
+  Local<Object> result = Object::New(
+      isolate, Null(isolate), keys.data(), values.data(), keys.size());
   args.GetReturnValue().Set(result);
 }
 
@@ -554,8 +555,9 @@ void StatementSync::IterateNextCallback(
     LocalVector<Value> values(isolate,
                               {Boolean::New(isolate, true), Null(isolate)});
 
-    Local<Object> result =
-        Object::New(isolate, Null(isolate), keys.data(), values.data(), 2);
+    DCHECK_EQ(keys.size(), values.size());
+    Local<Object> result = Object::New(
+        isolate, Null(isolate), keys.data(), values.data(), keys.size());
     args.GetReturnValue().Set(result);
     return;
   }
@@ -579,8 +581,9 @@ void StatementSync::IterateNextCallback(
   LocalVector<Name> keys(isolate, {env->done_string(), env->value_string()});
   LocalVector<Value> values(isolate, {Boolean::New(isolate, false), row});
 
-  Local<Object> result =
-      Object::New(isolate, Null(isolate), keys.data(), values.data(), 2);
+  DCHECK_EQ(keys.size(), values.size());
+  Local<Object> result = Object::New(
+      isolate, Null(isolate), keys.data(), values.data(), keys.size());
   args.GetReturnValue().Set(result);
 }
 
@@ -629,8 +632,9 @@ void StatementSync::Iterate(const FunctionCallbackInfo<Value>& args) {
           .ToLocalChecked()
           .As<Object>();
 
+  DCHECK_EQ(keys.size(), values.size());
   Local<Object> iterable_iterator = Object::New(
-      isolate, js_iterator_prototype, keys.data(), values.data(), 2);
+      isolate, js_iterator_prototype, keys.data(), values.data(), keys.size());
   args.GetReturnValue().Set(iterable_iterator);
 }