Integrate Siri shortcuts to enable/disable gps tracking #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
????? |
tananaev
reviewed
Dec 28, 2024
| let userDefaults = UserDefaults.standard | ||
| if !userDefaults.bool(forKey: "service_status_preference") { | ||
| userDefaults.setValue(true, forKey: "service_status_preference") | ||
| await StatusViewController.addMessage(NSLocalizedString("Tracking Service created", comment: "")) |
| trackingController = TrackingController() | ||
| trackingController?.start() | ||
| } | ||
| return .result(dialog: "Tracking Service Started") |
There was a problem hiding this comment.
This should probably be localized as well. And probably reuse string as well.
| @available(iOS 16, *) | ||
| struct StartTrackingIntent: AppIntent { | ||
|
|
||
| static let title: LocalizedStringResource = "Start Tracking Service" |
| import SwiftUI | ||
|
|
||
| @available(iOS 16, *) | ||
| struct StopTrackingIntent: AppIntent { |
| <key>INIntentConfigurable</key> | ||
| <true/> | ||
| <key>INIntentDescription</key> | ||
| <string>starts tracking with gps</string> |
There was a problem hiding this comment.
I don't think this is a correct description. It doesn't necessarily use GPS. Also need proper letter cases
| </dict> | ||
| </dict> | ||
| <key>INIntentName</key> | ||
| <string>StartTrackingService</string> |
There was a problem hiding this comment.
In this file I only see the start track intent. Where is the stop defined?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds Siri and Shortcuts integration to the app, enhancing the user experience by enabling voice commands and quick actions. My main goal was to enable/disable the GPS tracking service using automations (eg. when i start driving)
Changes
Testing
Unfortunately due to the Siri integration requiring a paid Apple Developer Account, i was not able to test this outside of the simulator, where everything works perfectly .