Add data compression to PositionForwarderWialon #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tananaev
reviewed
Oct 25, 2024
Comment on lines
157
to
148
| ByteArrayOutputStream container = new ByteArrayOutputStream(); | ||
|
|
||
| container.write(0xFF); | ||
|
|
||
| int dataLength = data.length; | ||
| ByteBuffer lengthBuffer = ByteBuffer.allocate(2).order(ByteOrder.LITTLE_ENDIAN); | ||
| lengthBuffer.putShort((short) dataLength); | ||
| container.write(lengthBuffer.array(), 0, 2); | ||
|
|
||
| container.write(data, 0, dataLength); | ||
|
|
||
| return container.toByteArray(); |
There was a problem hiding this comment.
Using Netty buffers can probably make this much cleaner.
Should i just wrap this feature with And maybe we need to change protocol version from hardcode at MainModule to config option? |
|
I think it would be better to just have a constructor parameter to enable/disable ZIP. |
Disabled by default? |
|
Yes, I prefer disabled by default because then the format will be compatible with Traccar. |
tananaev
reviewed
Oct 25, 2024
| @@ -111,6 +129,33 @@ public void forward(PositionData positionData, ResultHandler resultHandler) { | |||
| } | |||
| } | |||
|
|
|||
| public static byte[] compressData(byte[] data) { | |||
There was a problem hiding this comment.
I would probably just combine the two methods to avoid two buffers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If data is bigger then MTU, UDP won't allow to send this. I try to change UDP to TCP, chunk data, but compression do it's best.
Compression is described at the end of this docs: https://extapi.wialon.com/hw/cfg/Wialon%20IPS_en_v_2_0.pdf
Tested on Wialon and build looks fine.