Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to produce array of results for blocks #1081

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions interp/interp.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,8 @@ type opt struct {
stdin io.Reader // standard input
stdout io.Writer // standard output
stderr io.Writer // standard error

blockStmtAsArray bool
}

// Interpreter contains global resources and state.
Expand Down Expand Up @@ -244,6 +246,8 @@ type Options struct {
// They default to os.Stding, os.Stdout and os.Stderr respectively.
Stdin io.Reader
Stdout, Stderr io.Writer

BlockStatementAsArray bool
}

// New returns a new interpreter.
Expand Down Expand Up @@ -294,6 +298,8 @@ func New(options Options) *Interpreter {

// fastChan disables the cancellable version of channel operations in evalWithContext
i.opt.fastChan, _ = strconv.ParseBool(os.Getenv("YAEGI_FAST_CHAN"))

i.opt.blockStmtAsArray = options.BlockStatementAsArray
return &i
}

Expand Down Expand Up @@ -582,6 +588,12 @@ func (interp *Interpreter) eval(src, name string, inc bool) (res reflect.Value,
for _, n := range initNodes {
interp.run(n, interp.frame)
}

if interp.blockStmtAsArray && root.kind == blockStmt {
v := blockStmtAsArray(root, interp.frame)
return reflect.ValueOf(v), err
}

v := genValue(root)
res = v(interp.frame)

Expand All @@ -595,6 +607,31 @@ func (interp *Interpreter) eval(src, name string, inc bool) (res reflect.Value,
return res, err
}

// BlockResult is the result of a block statement.
type BlockResult []interface{}

func blockStmtAsArray(n *node, f *frame) BlockResult {
res := make(BlockResult, len(n.child))
for i, child := range n.child {
if child.kind == blockStmt {
res[i] = blockStmtAsArray(child, f)
continue
}

v := genValue(child)
rv := v(f)
if !rv.IsValid() {
continue
}

res[i] = rv.Interface()
if n, ok := res[i].(*node); ok {
res[i] = genFunctionWrapper(n)(f)
}
}
return res
}

// EvalWithContext evaluates Go code represented as a string. It returns
// a map on current interpreted package exported symbols.
func (interp *Interpreter) EvalWithContext(ctx context.Context, src string) (reflect.Value, error) {
Expand Down
9 changes: 9 additions & 0 deletions interp/interp_eval_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1490,3 +1490,12 @@ func TestREPLDivision(t *testing.T) {
t.Fatal("timeout")
}
}

func TestEvalBlockAsArray(t *testing.T) {
i := interp.New(interp.Options{BlockStatementAsArray: true})
runTests(t, i, []testCase{
{src: "a := 5", res: "[5]"},
{src: "a = 1; b := 2", res: "[1 2]"},
{src: "a = 3; {b = 4}", res: "[3 [4]]"},
})
}