Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interp: fix handling of redeclared variables in short declaration. #1650

Merged
merged 3 commits into from
Jul 18, 2024
Merged

interp: fix handling of redeclared variables in short declaration. #1650

merged 3 commits into from
Jul 18, 2024

Conversation

mvertes
Copy link
Member

@mvertes mvertes commented Jul 17, 2024

Fixes #1640.

@mvertes mvertes requested a review from mpl July 18, 2024 08:52
mpl
mpl approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker
Copy link
Contributor

🚫 the milestone is missing

@mvertes mvertes added this to the v0.16.x milestone Jul 18, 2024
@traefiker traefiker merged commit 94de0aa into traefik:master Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

Assignees
No one assigned
Labels
area/core bug Something isn't working
Projects
None yet
Milestone
v0.16.x
Development

Successfully merging this pull request may close these issues.

ShortVariableDeclarations features do not agree with golang standards
3 participants
@mvertes @traefiker @mpl