Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Checkmarx issues #290

Merged
merged 35 commits into from
Apr 24, 2023
Merged

Fix Checkmarx issues #290

merged 35 commits into from
Apr 24, 2023

Conversation

albarivas
Copy link
Contributor

What does this PR do?

Fix Checkmarx issues

What issues does this PR fix or reference?

#

The PR fulfills these requirements:

[N/A] Tests for the proposed changes have been added/updated.
[x] Code linting and formatting was performed.

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@albarivas albarivas requested a review from a team as a code owner December 28, 2022 15:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 28, 2022 •
edited
Loading

⚠️ CodeTour Watch

Changed files with possible CodeTour impact:

  • force-app/main/default/classes/ListWithParentRecordDataControllerLwc.cls
  • force-app/main/default/lwc/pageBlocksWrapper/pageBlocksWrapper.html

Impacted CodeTour files:

  • .tours/record-lists.tour - ⚠️ Missing from PR
  • .tours/welcome.tour - ⚠️ Missing from PR

Make sure to review CodeTour files and update line numbers accordingly.

pozil
pozil approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@pozil pozil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Looking great.

@pozil
Copy link
Contributor

pozil commented Dec 28, 2022

Waiting for Prettier plugin fix: dangmai/prettier-plugin-apex#738

@randi274 randi274 mentioned this pull request Apr 20, 2023
Closed
@RitamAgrawal RitamAgrawal mentioned this pull request Apr 21, 2023
Merged
pozil and others added 21 commits April 24, 2023 08:49
@pozil
ci: got rid of ::set-output
f5309ef
@pozil
ci: bumped to checkout@v3
fcb7468
@pozil
ci: switched sfdx install to npm
9aced54
@dependabot @pozil
build(deps-dev): bump eslint from 8.31.0 to 8.33.0
ce2e812 
Bumps [eslint](https://github.com/eslint/eslint) from 8.31.0 to 8.33.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.31.0...v8.33.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump prettier from 2.8.1 to 2.8.3
2a2dc46 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.3.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.1...2.8.3)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @lwc/eslint-plugin-lwc from 1.5.0 to 1.5.1
b2d6d44 
Bumps [@lwc/eslint-plugin-lwc](https://github.com/salesforce/eslint-plugin-lwc) from 1.5.0 to 1.5.1.
- [Release notes](https://github.com/salesforce/eslint-plugin-lwc/releases)
- [Commits](salesforce/eslint-plugin-lwc@v1.5.0...v1.5.1)

---
updated-dependencies:
- dependency-name: "@lwc/eslint-plugin-lwc"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump eslint-plugin-jest from 27.2.0 to 27.2.1
086508e 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 27.2.0 to 27.2.1.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.2.0...v27.2.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @salesforce/eslint-config-lwc from 3.3.3 to 3.3.4
74800c0 
Bumps [@salesforce/eslint-config-lwc](https://github.com/salesforce/eslint-config-lwc) from 3.3.3 to 3.3.4.
- [Release notes](https://github.com/salesforce/eslint-config-lwc/releases)
- [Commits](salesforce/eslint-config-lwc@v3.3.3...v3.3.4)

---
updated-dependencies:
- dependency-name: "@salesforce/eslint-config-lwc"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump husky from 8.0.2 to 8.0.3
a7f4e67 
Bumps [husky](https://github.com/typicode/husky) from 8.0.2 to 8.0.3.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v8.0.2...v8.0.3)

---
updated-dependencies:
- dependency-name: husky
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump eslint-plugin-import from 2.26.0 to 2.27.5
f5721ee 
Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.26.0 to 2.27.5.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.26.0...v2.27.5)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@pozil
ci: bumped codecov to v3
83c28a4
@pozil
ci: bumped codetour-watch to v2
90d2576
@pozil
ci: updated PR actions
4cc2b41
@pozil
ci: updated checkout actions
c902cb9
@pozil
ci: add manual packaging trigger
6947870
@trailheadapps-bot @github-actions @pozil
Released new package version 04t3h0000043uxVAAQ (#306)
332f201 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dependabot @pozil
build(deps-dev): bump @lwc/eslint-plugin-lwc from 1.5.1 to 1.6.2
fa13f84 
Bumps [@lwc/eslint-plugin-lwc](https://github.com/salesforce/eslint-plugin-lwc) from 1.5.1 to 1.6.2.
- [Release notes](https://github.com/salesforce/eslint-plugin-lwc/releases)
- [Commits](salesforce/eslint-plugin-lwc@v1.5.1...v1.6.2)

---
updated-dependencies:
- dependency-name: "@lwc/eslint-plugin-lwc"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @salesforce/sfdx-lwc-jest from 1.2.1 to 1.3.0
5dcdb97 
Bumps [@salesforce/sfdx-lwc-jest](https://github.com/salesforce/sfdx-lwc-jest) from 1.2.1 to 1.3.0.
- [Release notes](https://github.com/salesforce/sfdx-lwc-jest/releases)
- [Changelog](https://github.com/salesforce/sfdx-lwc-jest/blob/master/CHANGELOG.md)
- [Commits](https://github.com/salesforce/sfdx-lwc-jest/commits/v1.3.0)

---
updated-dependencies:
- dependency-name: "@salesforce/sfdx-lwc-jest"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump lint-staged from 13.1.0 to 13.1.2
5cec870 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.1.0 to 13.1.2.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v13.1.0...v13.1.2)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @sa11y/jest from 4.1.1 to 4.1.3
2a32a91 
Bumps [@sa11y/jest](https://github.com/salesforce/sa11y/tree/HEAD/packages/jest) from 4.1.1 to 4.1.3.
- [Release notes](https://github.com/salesforce/sa11y/releases)
- [Changelog](https://github.com/salesforce/sa11y/blob/master/CHANGELOG.md)
- [Commits](https://github.com/salesforce/sa11y/commits/v4.1.3/packages/jest)

---
updated-dependencies:
- dependency-name: "@sa11y/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump eslint from 8.33.0 to 8.35.0
8ff2f19 
Bumps [eslint](https://github.com/eslint/eslint) from 8.33.0 to 8.35.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.33.0...v8.35.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
dependabot bot and others added 11 commits April 24, 2023 08:50
@dependabot @pozil
build(deps-dev): bump prettier from 2.8.3 to 2.8.4
0ee7f3f 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.3 to 2.8.4.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.3...2.8.4)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @salesforce/eslint-config-lwc from 3.3.4 to 3.4.0
25a1949 
Bumps [@salesforce/eslint-config-lwc](https://github.com/salesforce/eslint-config-lwc) from 3.3.4 to 3.4.0.
- [Release notes](https://github.com/salesforce/eslint-config-lwc/releases)
- [Commits](salesforce/eslint-config-lwc@v3.3.4...v3.4.0)

---
updated-dependencies:
- dependency-name: "@salesforce/eslint-config-lwc"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@pozil
ci: removed coverage file deletion (temp workaround)
2d0b4ff
@dependabot @pozil
build(deps-dev): bump lint-staged from 13.1.2 to 13.2.0
e8728d2 
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 13.1.2 to 13.2.0.
- [Release notes](https://github.com/okonet/lint-staged/releases)
- [Commits](lint-staged/lint-staged@v13.1.2...v13.2.0)

---
updated-dependencies:
- dependency-name: lint-staged
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump @sa11y/jest from 4.1.3 to 4.1.5
8290faf 
Bumps [@sa11y/jest](https://github.com/salesforce/sa11y/tree/HEAD/packages/jest) from 4.1.3 to 4.1.5.
- [Release notes](https://github.com/salesforce/sa11y/releases)
- [Changelog](https://github.com/salesforce/sa11y/blob/master/CHANGELOG.md)
- [Commits](https://github.com/salesforce/sa11y/commits/v4.1.5/packages/jest)

---
updated-dependencies:
- dependency-name: "@sa11y/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump prettier from 2.8.4 to 2.8.7
b4114a2 
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.4 to 2.8.7.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.8.4...2.8.7)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot @pozil
build(deps-dev): bump eslint from 8.35.0 to 8.37.0
76cbb65 
Bumps [eslint](https://github.com/eslint/eslint) from 8.35.0 to 8.37.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.35.0...v8.37.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@albarivas @pozil
Upgrade prettier
15a6854
@pozil
build: bumped dependencies
682fa16
@pozil
Merge branch 'main' into ar/fix-checkmarx-issues
4d9d47b
@pozil
build: bumped dependencies
476c320
@pozil pozil merged commit 3924a81 into main Apr 24, 2023
@pozil pozil deleted the ar/fix-checkmarx-issues branch April 24, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pozil pozil pozil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albarivas @pozil @trailheadapps-bot