Algorithm fixes #174
Merged
Algorithm fixes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* open to discussion about line 151 - previous output was intentional (to maintain an original name as the suggested name, if no aligned name), but looks weird in comparison to outputs from other tools * for genus-resolution names where the genus is outdated, the genus-column was being updated, but the new genus wasn't being "inserted" into the suggested name due to a typo in lines 279/280
add `strip_names_2`
trying to fix test
revert last commit
Continue setting aligned names to `NA` if no family, genus, species, infraspecies match - in both matches and tests (I think something still wrong with diversity tests - maybe to do with APC/APNI versions.)
dfalster
requested changes
Jan 22, 2024
requested changes made (before this tests passing - but didn't wait for final one)
dfalster
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small algorithm fixes
strip_names_2suggested_nameblank if not even genus/family can be aligned(From Dec - first of 2 branches to merge)