Bug fix, re-number match algorithms #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renumber match algorithms in online table to be identical to manuscript
* update match codes in `match_taxa`
* edit function `extract_genus` to make genus uppercase * edit match algorithms to ensure genus names match equivalent columns in resources and submitted names; previously comparing `canonical names` from resources with `genus` from submitted name derivations. Changes to `extract_genus` function probably good enough, but this should be standardised anyway
...acknowledging this commit might get reverted, but here for now.
fix match codes in tests
4 phrase names in APNI where the first word was a "family" and there were mistakenly ending up as genus names when resources loaded; caught by test failure
dfalster
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extract_genusto make genus uppercasecanonical namesfrom resources withgenusfrom submitted name derivations. Changes toextract_genusfunction probably good enough, but this should be standardised anywayAPC-knownwithAPC-synonyms