Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in prepartion for CRAN resubmission #251

Merged
merged 30 commits into from
Jan 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3599080
Bump version number (1.0.0.9000)
dfalster May 6, 2024
6acbeac
spelling fixes and removing special Mac install instructions (#229)
wcornwell May 29, 2024
c95ddb6
Cran preparations (#230)
fontikar May 30, 2024
8b7a619
cleaning up (#231)
wcornwell Jun 16, 2024
94254aa
fixing badges
wcornwell Jun 17, 2024
608aab2
Merge branch 'master' into develop
wcornwell Jun 17, 2024
d4f2379
Tweaks (#234)
slager Jun 20, 2024
379ca6b
testing for issue #235
wcornwell Jul 31, 2024
48567b4
still working on #235
wcornwell Jul 31, 2024
3798dcc
one more try to find the edge case
wcornwell Jul 31, 2024
ec50f22
another edge case?
wcornwell Jul 31, 2024
6e8a768
reformat code in release file
wcornwell Jul 31, 2024
724b6c9
another edge case
wcornwell Jul 31, 2024
98d8921
reverting previous commit to documentation
wcornwell Jul 31, 2024
a99fc67
adding check on resources to all functions that need resources
wcornwell Jul 31, 2024
adfee1c
bumping version number and updating readme
wcornwell Jul 31, 2024
281fbe5
missed two checking spots
wcornwell Jul 31, 2024
5102771
238 genus family lookup (#239)
wcornwell Aug 13, 2024
c4fa44d
bumping version number and updating news
wcornwell Aug 13, 2024
4ea4068
update readme
wcornwell Aug 13, 2024
3e637e6
Merge branch 'master' into develop
wcornwell Aug 13, 2024
238bda6
no empty lines in description
wcornwell Aug 13, 2024
64b386a
trying to atone for previous git sins
wcornwell Aug 28, 2024
c78090a
Merged in recent master release, bumped version number
fontikar Nov 19, 2024
8207db6
Added rhub checks as part of CI workflow
fontikar Dec 18, 2024
7295616
Bumped version number
fontikar Dec 18, 2024
656b65e
Safe guarding versions that come in from github API #248
fontikar Dec 20, 2024
559af47
Added error message when bad versions #249
fontikar Dec 20, 2024
9b9329e
Removing Shiny URL from README as it is currently down with Posit R p…
fontikar Dec 20, 2024
16f8923
All URLS are happy!
fontikar Dec 20, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 95 additions & 0 deletions .github/workflows/rhub.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
# R-hub's generic GitHub Actions workflow file. It's canonical location is at
# https://github.com/r-hub/actions/blob/v1/workflows/rhub.yaml
# You can update this file to a newer version using the rhub2 package:
#
# rhub::rhub_setup()
#
# It is unlikely that you need to modify this file manually.

name: R-hub
run-name: "${{ github.event.inputs.id }}: ${{ github.event.inputs.name || format('Manually run by {0}', github.triggering_actor) }}"

on:
workflow_dispatch:
inputs:
config:
description: 'A comma separated list of R-hub platforms to use.'
type: string
default: 'linux,windows,macos'
name:
description: 'Run name. You can leave this empty now.'
type: string
id:
description: 'Unique ID. You can leave this empty now.'
type: string

jobs:

setup:
runs-on: ubuntu-latest
outputs:
containers: ${{ steps.rhub-setup.outputs.containers }}
platforms: ${{ steps.rhub-setup.outputs.platforms }}

steps:
# NO NEED TO CHECKOUT HERE
- uses: r-hub/actions/setup@v1
with:
config: ${{ github.event.inputs.config }}
id: rhub-setup

linux-containers:
needs: setup
if: ${{ needs.setup.outputs.containers != '[]' }}
runs-on: ubuntu-latest
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.containers) }}
container:
image: ${{ matrix.config.container }}

steps:
- uses: r-hub/actions/checkout@v1
- uses: r-hub/actions/platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/setup-deps@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/run-check@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}

other-platforms:
needs: setup
if: ${{ needs.setup.outputs.platforms != '[]' }}
runs-on: ${{ matrix.config.os }}
name: ${{ matrix.config.label }}
strategy:
fail-fast: false
matrix:
config: ${{ fromJson(needs.setup.outputs.platforms) }}

steps:
- uses: r-hub/actions/checkout@v1
- uses: r-hub/actions/setup-r@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/actions/platform-info@v1
with:
token: ${{ secrets.RHUB_TOKEN }}
job-config: ${{ matrix.config.job-config }}
- uses: r-hub/actions/setup-deps@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
- uses: r-hub/actions/run-check@v1
with:
job-config: ${{ matrix.config.job-config }}
token: ${{ secrets.RHUB_TOKEN }}
2 changes: 0 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

- Added `get_versions()`

# APCalign 1.1.0

- Create a genus->family lookup from the specified APC release

# APCalign 1.0.2
Expand Down
12 changes: 10 additions & 2 deletions R/load_taxonomic_resources.R
Original file line number Diff line number Diff line change
Expand Up @@ -411,8 +411,16 @@ default_version <- function() {
# Pull out versions
versions <- unique(release_data$tag_name)

# Exclude Taxonomy: first upload
dplyr::first(versions)
# Exclude rough semantic versions
cleaned_versions <- versions[!grepl("^\\d+\\.\\d+\\.\\d+(\\.\\d+)?$", versions)]

# Verify only dates left
if(! all(grepl("^\\d{4}-\\d{2}-\\d{2}$", cleaned_versions)))
rlang::abort("Inconsistent date formats detected in versions!")

# Return latest version
sort(cleaned_versions, decreasing = TRUE) |> #Sort from most recent to oldest
dplyr::first() # and take the first value after sorting
}
}

Expand Down
6 changes: 1 addition & 5 deletions README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,9 @@ get_apc_genus_family_lookup(c("Eucalyptus",
resources = tax_resources)
```

## Shiny application ✨

We also developed a shiny application for non-R users to update and align their taxonomic names. You can find the application here: https://unsw.shinyapps.io/APCalign-app

## Cheatsheet

<a href="https://github.com/traitecoevo/APCalign/tree/master/inst/cheatsheet/APCalign-cheatsheet.pdf"><img src="man/figures/APCalign-cheatsheet.png" width="60%"/></a>
<a href="https://github.com/traitecoevo/APCalign/blob/master/inst/cheatsheet/APCalign-cheatsheet.pdf"><img src="man/figures/APCalign-cheatsheet.png" width="60%"/></a>

## Learn more 📚

Expand Down
10 changes: 2 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,9 @@ get_apc_genus_family_lookup(c("Eucalyptus",
#> 6 Triodia Poaceae
```

## Shiny application ✨

We also developed a shiny application for non-R users to update and
align their taxonomic names. You can find the application here:
<https://unsw.shinyapps.io/APCalign-app>

## Cheatsheet

<a href="https://github.com/traitecoevo/APCalign/tree/master/inst/cheatsheet/APCalign-cheatsheet.pdf"><img src="man/figures/APCalign-cheatsheet.png" width="60%"/></a>
<a href="https://github.com/traitecoevo/APCalign/blob/master/inst/cheatsheet/APCalign-cheatsheet.pdf"><img src="man/figures/APCalign-cheatsheet.png" width="60%"/></a>

## Learn more 📚

Expand All @@ -143,7 +137,7 @@ vignette to learn about how to use `APCalign`. You can also learn more
about our [taxa matching
algorithm](https://traitecoevo.github.io/APCalign/articles/updating-taxon-names.html).

## Show us support 💚
## Show us support 💛

Please consider citing our work, we are really proud of it!

Expand Down
4 changes: 1 addition & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@


* This is a resubmission
* More gracefully handling edge cases involving parts of the internet being down
* Better handling an error in the vignette specific to certain MacOS versions
* Improved handling for release tag versions from Github API
* Adding one user function for genus->family lookup


Loading