-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new study: Creek_2018 #721
base: develop
Are you sure you want to change the base?
Conversation
* Adding 7 studies with morphological trait data extracted from 7 state and national floras: "SAH_2023", "WAH_2023_1", "WAH_2023_2", "ABRS_2023", "RBGV_2023", "NHNSW_2023", "NTH_2023" * 30 traits added * trait values mostly mapped to those developed in vocabulary workshops, but a few additional terms were needed, especially for traits like leaf_base for which we previously had very little data * branch also includes some preliminary work on fire response traits and edits to water use/hydraulics traits --------- Co-authored-by: David Coleman <https://github.com/dcol2804> Co-authored-by: Sophie Yang <[email protected]>
Add large dataset on fire response, seed longevity and reproductive maturity of most taxa in the Northern Territory Herbarium database, compiled from the literature and expert review. Lizzy emailed the report to the author but he's on leave so merging now! --------- Co-authored-by: ehwenk <[email protected]>
Add 3 new studies from Nadia Santini looking at water relations Contributor has submitted her raw data files and reviewed all reports --------- Co-authored-by: Sophie Yang <[email protected]>
Add study examining how resprouting and propagule persistence are associated with grassland and shrubland habitats and other environmental and biotic variables. Lizzy has emailed the author and we are awaiting a response. --------- Co-authored-by: ehwenk <[email protected]>
Add study with seed storage location and fire response data (both resprouting and seedling recruitment) at the plot level after experimental fire treatments. The study also investigated density changes after fire, which I have not mapped. --------- Co-authored-by: ehwenk <[email protected]>
* edits to traits related to fire response and plant regeneration following one of the AusTraits vocabulary workshops * major change is renaming all `fire_response` related traits to `resprouting_capacity` * removing several derived traits that can be recreated from other trait values; in the coming 6 months we will create some scripts showing how current data can be analysed * remap values for some traits in NSWFRD_2014 to capture more data --------- Co-authored-by: Sophie Yang <[email protected]>
* add new study: Mitchell_2008 * no contact with data collector * some problems with archived data - for instance Kl data are identical to Ks, so not used. --------- Co-authored-by: yangsophieee <[email protected]>
* add new study: Kocacinar_2003 * contacted authors for additional traits and individual-level data, but haven't heard back, so merging in data that are available in the manuscript --------- Co-authored-by: yangsophieee <[email protected]>
* old study and data extracted from tables and figures in paper --------- Co-authored-by: yangsophieee <[email protected]>
* add new study * data transcribed from manuscript & author not contacted --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Britton_1994 * First study with recruitment_time * transcribed data from manuscript; no contact with author --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Cowling_1987 * data on germination & flowering relative to fire for 4 WA Banksia species * data transcribed from manuscript; no contact with author --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Auld_2000 * dataset with seedbank longevity half-lives --------- Co-authored-by: yangsophieee <[email protected]>
* edit metadata_create_template to add proper fields for data_collectors * Tweak and add tests --------- Co-authored-by: Daniel Falster <[email protected]>
* Add new study: Tsakalos_2022 * large dataset documenting clonal spread mechanisms and bud bank locations for WA taxa * dataset available online, but will contact author --------- Co-authored-by: yangsophieee <[email protected]>
* Add new study: Brodribb_2000 * data transcribed from manuscript * author not contacted, as this is an older study --------- Co-authored-by: GillianKowalick Co-authored-by: yangsophieee <[email protected]>
This reverts commit c2bcb1b.
* Add new study: Collette_2021 * Large study looking at seed dormancy across Australia * Data from supplementary material; authors have not yet responded to email --------- Co-authored-by: yangsophieee <[email protected]>
Codecov ReportPatch and project coverage have no change.
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
========================================
Coverage 80.20% 80.20%
========================================
Files 7 7
Lines 1531 1531
========================================
Hits 1228 1228
Misses 303 303 ☔ View full report in Codecov by Sentry. |
Let's leave this pull request for a few days. I've just one of the authors on the paper - because I think this is a dataset where we'd prefer to have the individual-level values so we can properly capture all the context properties. |
* add new study * data transcribed from paper --------- Co-authored-by: yangsophieee <[email protected]>
Add study on growth and storage traits of post-fire seedlings in Mediterranean ecosystems of south-western Australia. I originally transcribed it in long format because that was easiest, but I changed it into wide format (see Pate_1990_extra_R_code.R) because there were some warning messages associated with it being in long format. --------- Co-authored-by: ehwenk <[email protected]>
* Flora data fixes Covering 2022 traits which are in the current release and 2023 traits which will be in the next version. * Aligned the growth form and woodiness to correct version
* script to generate traits.yml from APD data files (APD_traits.csv & APD_categorical_values.csv) * APD files are pulled directly from github APD repository * use script to updates traits.yml from APD version 1.0.0 ensure in final version of traits.yml (in the future): - ''' (3 single quotes) don't exist; should be ' (1 single quote) - there are no instances of `allowed_values_levels: {}` closes issue #727 --------- Co-authored-by: Daniel Falster <[email protected]>
add study - seed germination data from Kings Park, WA botanic garden --------- Co-authored-by: yangsophieee <[email protected]>
- Added additional raw data files from Caroline Nano for NT fire response - Filtered out duplicate taxa for `resprouting_capacity` data from Simpson_2021 (where it cites Crowley_2007) --------- Co-authored-by: ehwenk <[email protected]>
Small dataset of bark thickness index values. There is a lot more raw data supposedly in the study but we decided to not contact the author. --------- Co-authored-by: Elizabeth Wenk <[email protected]>
* add 3 traits to scraped data files, `plant_photosynthetic_organ`, `leaf_lamina_posture` and `leaf_margin_posture` to scraped flora data files --------- Co-authored-by: yangsophieee <[email protected]>
* add additional hydraulics traits * remove funny characters in taxon names * remove info for data columns that are unlikely to ever be considered "traits" (have left info in questions section)
I haven't heard back from anyone about the data set and feel like it is now too late to try and source the data before I leave. I've reviewed it, added in some new traits, and I think the right decision for now is to merge this in and we can revisit it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good for now and hopefully at some point we'll input the raw data set. But let's merge for now.
Daniel has asked that we do not merge this yet. And I've just updated the units based on the reasoning that the water potential at 12, 50 and 88 percent loss of conductivity for leaf, stem and root are based on the drought response experiment, hence replicates = 15-20.
|
Add study on coordination between leaf, stem, and root hydraulics and gas exchange in three arid-zone angiosperms during severe drought and recovery.
Questions for review: