Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename function #784

Merged
merged 1 commit into from
Nov 15, 2023
Merged

rename function #784

merged 1 commit into from
Nov 15, 2023

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Nov 15, 2023

build_update_taxonomy -> dataset_update_taxonomy to be consistent, since this function now occurs on each dataset.

`build_update_taxonomy` -> `dataset_update_taxonomy` to be consistent, since this function now occurs on each dataset.
@ehwenk ehwenk requested a review from dfalster November 15, 2023 05:17
@dfalster
Copy link
Member

dfalster commented Nov 15, 2023

Good thinking, but this file should be deleted!!! Is now being delivered from traits.build

@ehwenk
Copy link
Collaborator Author

ehwenk commented Nov 15, 2023

Good thinking, but this file should be deleted!!! Is now being delivered from traits.build

It is deleted on the other branch waiting to merge. @dfalster

@dfalster
Copy link
Member

Ok, I haven't received a receipt request for the other branch. This PR can be closed then

@ehwenk ehwenk merged commit 10dbdf1 into develop Nov 15, 2023
1 check passed
@ehwenk ehwenk deleted the rename-function-`build_update_taxonomy` branch November 15, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants