Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded files #785

Merged
merged 4 commits into from
Nov 16, 2023
Merged

Remove unneeded files #785

merged 4 commits into from
Nov 16, 2023

Conversation

ehwenk
Copy link
Collaborator

@ehwenk ehwenk commented Nov 15, 2023

remove test files, draft traits.build ontology (from a year ago), and files in inst/support that are sourced from traits.build

@ehwenk ehwenk requested a review from dfalster November 15, 2023 10:20
@dfalster
Copy link
Member

Hi @ehwenk We want to keep the contents of tests/build so I have recovered this, also another file functions.R that was lost some time ago.

Looking at this, I noted that the test/build is no longer running routinely and is out of date. I have updated it to run but it's no longer passing.

You can try it with testthat::test_dir("tests/build/")

we can review what is needed here.

Copy link
Member

@dfalster dfalster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go ahead and merge

@ehwenk ehwenk merged commit 3aebe9a into develop Nov 16, 2023
1 check passed
@ehwenk ehwenk deleted the remove-unneeded-files branch November 16, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants